Fix race condition on GPU #4542
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
… using bfc_allocator
ymwangg force-pushed the fix_race_condition branch from 168d1eb to 55652cd Compare 
JackCaoG reviewed Jan 31, 2023
JackCaoG approved these changes Feb 1, 2023
| Thanks @ymwangg ! |
| FYI @alanwaketan since we can enable the DDP test for GPU now. |
mateuszlewko pushed a commit that referenced this pull request Mar 15, 2023
… using bfc_allocator (#4542)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
This is a temporary fix for #4541 until it can be fixed on tensorflow side.
Btw: this PR should also fix the flaky ddp test on GPU.