Skip to content

Conversation

@yeounoh
Copy link
Contributor

@yeounoh yeounoh commented Dec 15, 2022

Introduce CopyToDevice in PjRtComputationClient to support d2d data transfer. The feature is tested as part of TEST_F(XLAShardingTest, InputHandler) for correctness.

@yeounoh yeounoh added runtime distributed SPMD and other distributed things. labels Dec 15, 2022
@yeounoh yeounoh self-assigned this Dec 15, 2022
Copy link
Collaborator

@jonb377 jonb377 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks Yeounoh! 🔥

Copy link
Collaborator

@will-cromar will-cromar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@JackCaoG
Copy link
Collaborator

Is this mainly to avoid the device->host->device overhead? Does this only works within the addressable device?

@yeounoh
Copy link
Contributor Author

yeounoh commented Dec 15, 2022

Is this mainly to avoid the device->host->device overhead? Does this only works within the addressable device?

Yes, these are highlighted with the two XLA_CHECK

@yeounoh yeounoh merged commit 5eaea4c into master Dec 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

distributed SPMD and other distributed things. runtime

4 participants