network structure diagram for sine wave example #209
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Member
| Hi @andreh7 I recognize this a very late review but do you mind adding your image to the appropriate README.md and showing me what it looks like? |
Contributor Author
| Let's abandon it, this is too long ago... |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
This is a proposal to add a .png file with the (folded) network structure implemented by time_sequence_prediction/train.py .
If another file format is more suitable, let me know -- I implemented this diagram using pyx, I can also put the graph generating python code here.
(graphviz does not support orthogonal edges with record nodes well hence the use of pyx)