Skip to content

Conversation

@tugsbayasgalan
Copy link

Summary: I don't know why source_fn_stack is disappeared but i think relying on nn_module_stack is better

Differential Revision: D85959415

@pytorch-bot
Copy link

pytorch-bot bot commented Oct 31, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/3268

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

✅ No Failures

As of commit 14bc2c0 with merge base 315e9b4 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 31, 2025
@meta-codesync
Copy link

meta-codesync bot commented Oct 31, 2025

@tugsbayasgalan has exported this pull request. If you are a Meta employee, you can view the originating Diff in D85959415.

@jerryzh168 jerryzh168 added the topic: not user facing Use this tag if you don't want this PR to show up in release notes label Oct 31, 2025
@jerryzh168 jerryzh168 requested a review from angelayi October 31, 2025 16:06
Copy link
Contributor

@angelayi angelayi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be equivalent!

node.target == torch.ops.aten.add_.Tensor
and node.args[0].op == "get_attr"
and node.args[1] == 1
and torch.nn.modules.batchnorm.BatchNorm2d
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this needs to be a string instead according to this:

Image
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

Summary: I don't know why source_fn_stack is disappeared but i think relying on nn_module_stack is better Reviewed By: angelayi Differential Revision: D85959415
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported meta-exported topic: not user facing Use this tag if you don't want this PR to show up in release notes

4 participants