Skip to content

fix: typing issue in Python 3.9 and earlier #3431

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
zewenli98 merged 1 commit into from
Mar 7, 2025
Merged

fix: typing issue in Python 3.9 and earlier #3431

zewenli98 merged 1 commit into from
Mar 7, 2025

Conversation

@zewenli98
Copy link
Collaborator

@zewenli98 zewenli98 commented Mar 6, 2025

Description

This PR changed List[Any], Dict[str, int] | None to Union[List[Any], Dict[str, int], None]

Python 3.9 and earlier don't support this way. For compatibility, we need to use the Union style.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code follows the style guidelines of this project (You can use the linters)
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas and hacks
  • I have made corresponding changes to the documentation
  • I have added tests to verify my fix or my feature
  • New and existing unit tests pass locally with my changes
  • I have added the relevant labels to my PR in so that relevant reviewers are notified
@zewenli98 zewenli98 self-assigned this Mar 6, 2025
@github-actions github-actions bot added component: conversion Issues re: Conversion stage component: api [Python] Issues re: Python API component: runtime component: dynamo Issues relating to the `torch.compile` or `torch._dynamo.export` paths labels Mar 6, 2025
@github-actions github-actions bot requested a review from gs-olive March 6, 2025 19:42
@zewenli98 zewenli98 removed the request for review from gs-olive March 6, 2025 19:45
narendasan
narendasan approved these changes Mar 7, 2025
View reviewed changes
Copy link
Collaborator

@narendasan narendasan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
peri044
peri044 approved these changes Mar 7, 2025
View reviewed changes
Copy link
Collaborator

@peri044 peri044 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
@zewenli98 zewenli98 merged commit 232cdc9 into main Mar 7, 2025
319 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla signed component: api [Python] Issues re: Python API component: conversion Issues re: Conversion stage component: dynamo Issues relating to the `torch.compile` or `torch._dynamo.export` paths component: runtime

5 participants

@zewenli98 @narendasan @peri044 @facebook-github-bot