Mutable module improvement #3394
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
github-actions bot added documentation 
cehongwang force-pushed the mutable_module_improvement branch 2 times, most recently from 210bd3a to 02011eb Compare github-actions bot removed documentation cehongwang force-pushed the mutable_module_improvement branch 3 times, most recently from f183050 to 9580f92 Compare 
cehongwang force-pushed the mutable_module_improvement branch from 3db0aec to ec2d674 Compare 
narendasan reviewed Feb 18, 2025
py/torch_tensorrt/dynamo/runtime/_MutableTorchTensorRTModule.py Outdated Show resolved Hide resolved
py/torch_tensorrt/dynamo/runtime/_MutableTorchTensorRTModule.py Outdated Show resolved Hide resolved
py/torch_tensorrt/dynamo/runtime/_MutableTorchTensorRTModule.py Outdated Show resolved Hide resolved
py/torch_tensorrt/dynamo/runtime/_MutableTorchTensorRTModule.py Outdated Show resolved Hide resolved
cehongwang force-pushed the mutable_module_improvement branch from 0ca42f3 to 0643d96 Compare 
peri044 reviewed Feb 18, 2025
py/torch_tensorrt/dynamo/runtime/_MutableTorchTensorRTModule.py Outdated Show resolved Hide resolved
py/torch_tensorrt/dynamo/runtime/_MutableTorchTensorRTModule.py Outdated Show resolved Hide resolved
cehongwang force-pushed the mutable_module_improvement branch 6 times, most recently from a5ea97b to a59d92d Compare cehongwang force-pushed the mutable_module_improvement branch from a59d92d to a8e0b48 Compare narendasan reviewed Feb 25, 2025
narendasan reviewed Feb 25, 2025
Collaborator
narendasan left a comment
narendasan left a comment There was a problem hiding this comment.
Do you have the persistent cache example?
cehongwang force-pushed the mutable_module_improvement branch from cef1620 to 1a309b8 Compare 
Collaborator Author
I talked to Boris and it seems like save and load is what he is looking for. I am adding engine caching example to MutableTorchTensorRTModule as well. |
cehongwang force-pushed the mutable_module_improvement branch from 7cf4ad9 to 76437f9 Compare peri044 reviewed Feb 27, 2025
Collaborator
peri044 left a comment
peri044 left a comment There was a problem hiding this comment.
Mostly LGTM. Added minor comments
py/torch_tensorrt/dynamo/runtime/_MutableTorchTensorRTModule.py Outdated Show resolved Hide resolved
py/torch_tensorrt/dynamo/runtime/_MutableTorchTensorRTModule.py Outdated Show resolved Hide resolved
cehongwang force-pushed the mutable_module_improvement branch from d3b94c2 to dd97ec2 Compare Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Fixes # (issue)
Type of change
Please delete options that are not relevant and/or add your own.
Checklist: