Skip to content

[reland] SDPA decomposition #3336

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
peri044 merged 4 commits into from
Feb 26, 2025
Merged

[reland] SDPA decomposition #3336

peri044 merged 4 commits into from
Feb 26, 2025

Conversation

@HolyWu
Copy link
Contributor

@HolyWu HolyWu commented Dec 22, 2024 •
edited
Loading

Description

Fixes #3252
Fixes #3333
Fixes #3392

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code follows the style guidelines of this project (You can use the linters)
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas and hacks
  • I have made corresponding changes to the documentation
  • I have added tests to verify my fix or my feature
  • New and existing unit tests pass locally with my changes
  • I have added the relevant labels to my PR in so that relevant reviewers are notified
@pytorch-bot pytorch-bot bot added the ci-no-td label Dec 22, 2024
@github-actions github-actions bot added component: tests Issues re: Tests component: lowering Issues re: The lowering / preprocessing passes component: conversion Issues re: Conversion stage component: converters Issues re: Specific op converters component: api [Python] Issues re: Python API component: dynamo Issues relating to the `torch.compile` or `torch._dynamo.export` paths labels Dec 22, 2024
@github-actions github-actions bot requested a review from gs-olive December 22, 2024 09:24
@narendasan narendasan requested a review from peri044 December 23, 2024 18:22
@peri044
Copy link
Collaborator

peri044 commented Feb 25, 2025

@HolyWu This PR looks good to me and I rebased it internally and tested with Flux model and #3392 is fixed as well. Can you rebase this PR ?
@peri044 peri044 merged commit 5100388 into pytorch:main Feb 26, 2025
50 of 68 checks passed
@HolyWu HolyWu deleted the sdpa_decomp branch February 27, 2025 12:34
@HolyWu HolyWu mentioned this pull request Feb 27, 2025
Closed
apbose pushed a commit that referenced this pull request Mar 2, 2025
@HolyWu @apbose
[reland] SDPA decomposition (#3336)
0790564
apbose pushed a commit that referenced this pull request Mar 2, 2025
@HolyWu @apbose
[reland] SDPA decomposition (#3336)
164cde1
@chohk88 chohk88 linked an issue Apr 23, 2025 that may be closed by this pull request
🐛 [Bug] torch._subclasses.fake_tensor.MetadataMismatchError: Devices cpu and cuda:0 are not equal! (_scaled_dot_product_flash_attention) #3408
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci-no-td cla signed component: api [Python] Issues re: Python API component: conversion Issues re: Conversion stage component: converters Issues re: Specific op converters component: dynamo Issues relating to the `torch.compile` or `torch._dynamo.export` paths component: lowering Issues re: The lowering / preprocessing passes component: tests Issues re: Tests

3 participants

@HolyWu @peri044 @facebook-github-bot