Skip to content

Conversation

@ydcjeff
Copy link
Contributor

@ydcjeff ydcjeff commented Apr 6, 2021

Description: Only show important templates files as suggested by @vfdev-5
For the tree view, streamlit doesn't allow nested columns or expanders currently.

@ydcjeff ydcjeff added enhancement New feature or request frontend Vue app labels Apr 6, 2021
@ydcjeff ydcjeff added this to the v0.1.0 milestone Apr 6, 2021
@ydcjeff ydcjeff requested a review from vfdev-5 April 6, 2021 06:56
@vfdev-5
Copy link
Member

vfdev-5 commented Apr 6, 2021

@ydcjeff thanks for the PR, however hiding files I think could be misleading once the archive is downloaded...

Let's think more about the way to improve our UI ...

EDIT: how about https://docs.streamlit.io/en/stable/api.html#streamlit.beta_expander ?

Another comment about render_directory method, I think you can easily generate tree view with rich library, see the usage: https://gist.github.com/tonyfast/3d0a94dc3a8db102aa06f9c930116993

@ydcjeff
Copy link
Contributor Author

ydcjeff commented Apr 6, 2021

EDIT: how about https://docs.streamlit.io/en/stable/api.html#streamlit.beta_expander ?

We are already using beta_expander

@ydcjeff ydcjeff changed the base branch from master to dev April 20, 2021 14:45
@ydcjeff ydcjeff closed this May 10, 2021
@ydcjeff ydcjeff deleted the templates-only branch May 10, 2021 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request frontend Vue app

2 participants