Added Python-Fire as Default Argument Parser

.github/workflows/ci.yml

@@ -80,13 +80,21 @@ jobs:
  pip install tqdm
 
  - run: pnpm build
- - run: pnpm test:ci
+
+ - name: pnpm test:ci ${{ matrix.template }}
+ env:
+ NPM_CONFIG: ${{ matrix.template }}
+ run: pnpm test:ci
+
  - run: sh ./scripts/run_tests.sh unzip
- - run: pnpm dist_lint
+ - run: pnpm dist_lint ${{ matrix.template }}
 
  - name: 'Run ${{ matrix.template }} ${{ matrix.test }}'
  run: sh ./scripts/run_tests.sh ${{ matrix.test }} ${{ matrix.template }}
 
+ - name: 'Run ${{ matrix.template }} ${{ matrix.test }} - Python Fire'
+ run: sh ./scripts/run_tests_fire.sh ${{ matrix.test }} ${{ matrix.template }}
+
  lint:
  runs-on: ubuntu-latest
  steps:

__tests__/text-classification.spec.js

@@ -24,169 +24,201 @@ afterEach(async () => {
  await context.close()
 })
 
-test('text classification simple', async () => {
- await page.selectOption('select', 'template-text-classification')
-
- await page.waitForSelector('text=README.md')
-
- await page.click('text=Loggers')
- await page.click('text=config.yaml')
-
- // TODO: simplify the downloadPromise calls
- // Here we are trying to wait for 2 seconds before clicking on the `Code` and `Download Zip` button
- const downloadPromise = await page
- .waitForEvent('download', { timeout: 2000 })
- .catch(() => {
- page.getByRole('button', { name: 'Code' }).click()
- page.getByRole('button', { name: 'Download Zip' }).click()
- return page.waitForEvent('download', { timeout: 2000 })
- })
- .catch(() => {
- // these catch calls are required to make sure if CI fails initially then we can have something to rely for further tests
- page.getByRole('button', { name: 'Code' }).click()
- page.getByRole('button', { name: 'Download Zip' }).click()
- return page.waitForEvent('download', { timeout: 2000 })
- })
- .catch(() => {
- page.getByRole('button', { name: 'Code' }).click()
- page.getByRole('button', { name: 'Download Zip' }).click()
- return page.waitForEvent('download', { timeout: 2000 })
- })
-
- await downloadPromise.saveAs('./dist-tests/text-classification-simple.zip')
-})
-
-test('text classification all', async () => {
- await page.selectOption('select', 'template-text-classification')
-
- await page.check('#include_test-checkbox')
- expect(await page.isChecked('#include_test-checkbox')).toBeTruthy()
-
- await page.waitForSelector('text=README.md')
- await page.click('text=Training')
-
- await page.check('#deterministic-checkbox')
- expect(await page.isChecked('#deterministic-checkbox')).toBeTruthy()
-
- await page.click('text=Handlers')
-
- await page.check('#save_training-checkbox')
- expect(await page.isChecked('#save_training-checkbox')).toBeTruthy()
-
- await page.check('#save_evaluation-checkbox')
- expect(await page.isChecked('#save_evaluation-checkbox')).toBeTruthy()
-
- await page.fill('#filename_prefix-input-text', 'training')
- expect(await page.$eval('#filename_prefix-input-text', (e) => e.value)).toBe(
- 'training'
- )
-
- await page.fill('#save_every_iters-input-number', '2')
- expect(
- await page.$eval('#save_every_iters-input-number', (e) => e.value)
- ).toBe('2')
-
- await page.fill('#n_saved-input-number', '2')
- expect(await page.$eval('#n_saved-input-number', (e) => e.value)).toBe('2')
-
- await page.check('#terminate_on_nan-checkbox')
- expect(await page.isChecked('#terminate_on_nan-checkbox')).toBeTruthy()
-
- await page.fill('#patience-input-number', '2')
- expect(await page.$eval('#patience-input-number', (e) => e.value)).toBe('2')
-
- await page.fill('#limit_sec-input-number', '60')
- expect(await page.$eval('#limit_sec-input-number', (e) => e.value)).toBe('60')
-
- await page.click('text=Loggers')
- await page.click('text=config.yaml')
-
- const downloadPromise = await page
- .waitForEvent('download', { timeout: 2000 })
- .catch(() => {
- page.getByRole('button', { name: 'Code' }).click()
- page.getByRole('button', { name: 'Download Zip' }).click()
- return page.waitForEvent('download', { timeout: 2000 })
- })
- .catch(() => {
- page.getByRole('button', { name: 'Code' }).click()
- page.getByRole('button', { name: 'Download Zip' }).click()
- return page.waitForEvent('download', { timeout: 2000 })
- })
- .catch(() => {
- page.getByRole('button', { name: 'Code' }).click()
- page.getByRole('button', { name: 'Download Zip' }).click()
- return page.waitForEvent('download', { timeout: 2000 })
- })
- await downloadPromise.saveAs('./dist-tests/text-classification-all.zip')
-})
-
-test('text classification launch', async () => {
- await page.selectOption('select', 'template-text-classification')
-
- await page.waitForSelector('text=README.md')
- await page.click('text=Training')
-
- await page.check('#use_dist-checkbox')
- expect(await page.isChecked('#use_dist-checkbox')).toBeTruthy()
-
- expect(await page.isChecked('#dist-torchrun-radio')).toBeTruthy()
-
- await page.click('text=Loggers')
- await page.click('text=config.yaml')
-
- const downloadPromise = await page
- .waitForEvent('download', { timeout: 2000 })
- .catch(() => {
- page.getByRole('button', { name: 'Code' }).click()
- page.getByRole('button', { name: 'Download Zip' }).click()
- return page.waitForEvent('download', { timeout: 2000 })
- })
- .catch(() => {
- page.getByRole('button', { name: 'Code' }).click()
- page.getByRole('button', { name: 'Download Zip' }).click()
- return page.waitForEvent('download', { timeout: 2000 })
- })
- .catch(() => {
- page.getByRole('button', { name: 'Code' }).click()
- page.getByRole('button', { name: 'Download Zip' }).click()
- return page.waitForEvent('download', { timeout: 2000 })
- })
-
- await downloadPromise.saveAs('./dist-tests/text-classification-launch.zip')
-})
-
-test('text classification spawn', async () => {
- await page.selectOption('select', 'template-text-classification')
-
- await page.waitForSelector('text=README.md')
- await page.click('text=Training')
-
- await page.check('#use_dist-checkbox')
- expect(await page.isChecked('#use_dist-checkbox')).toBeTruthy()
-
- await page.check('#dist-spawn-radio')
- expect(await page.isChecked('#dist-spawn-radio')).toBeTruthy()
-
- await page.click('text=Loggers')
- await page.click('text=config.yaml')
-
- const downloadPromise = await page
- .waitForEvent('download', { timeout: 2000 })
- .catch(() => {
- page.getByRole('button', { name: 'Code' }).click()
- page.getByRole('button', { name: 'Download Zip' }).click()
- return page.waitForEvent('download', { timeout: 2000 })
- })
- .catch(() => {
- page.getByRole('button', { name: 'Code' }).click()
- page.getByRole('button', { name: 'Download Zip' }).click()
- return page.waitForEvent('download', { timeout: 2000 })
- })
- .catch(() => {
- page.getByRole('button', { name: 'Code' }).click()
- page.getByRole('button', { name: 'Download Zip' }).click()
- return page.waitForEvent('download', { timeout: 2000 })
- })
- await downloadPromise.saveAs('./dist-tests/text-classification-spawn.zip')
-})
+const parser = ['argparse', 'fire']
+for (const name of parser) {
+ test(`text-classification simple ${name}`, async () => {
+ await page.selectOption('select', 'template-text-classification')
+
+ await page.waitForSelector('text=README.md')
+
+ await page.click('text=Loggers')
+ await page.click('text=config.yaml')
+ await page.getByText('Training', { exact: true }).click()
+
+ await page
+ .getByRole('combobox', {
+ name: 'Select the argument parser for training'
+ })
+ .selectOption(`${name}`)
+ // TODO: simplify the downloadPromise calls
+ // Here we are trying to wait for 2 seconds before clicking on the `Code` and `Download Zip` button
+ const downloadPromise = await page
+ .waitForEvent('download', { timeout: 2000 })
+ .catch(() => {
+ page.getByRole('button', { name: 'Code' }).click()
+ page.getByRole('button', { name: 'Download Zip' }).click()
+ return page.waitForEvent('download', { timeout: 2000 })
+ })
+ .catch(() => {
+ // these catch calls are required to make sure if CI fails initially then we can have something to rely for further tests
+ page.getByRole('button', { name: 'Code' }).click()
+ page.getByRole('button', { name: 'Download Zip' }).click()
+ return page.waitForEvent('download', { timeout: 2000 })
+ })
+ .catch(() => {
+ page.getByRole('button', { name: 'Code' }).click()
+ page.getByRole('button', { name: 'Download Zip' }).click()
+ return page.waitForEvent('download', { timeout: 2000 })
+ })
+
+ await downloadPromise.saveAs(
+ `./dist-tests/text-classification-simple-${name}.zip`
+ )
+ })
+
+ test(`text-classification all ${name}`, async () => {
+ await page.selectOption('select', 'template-text-classification')
+
+ await page.check('#include_test-checkbox')
+ expect(await page.isChecked('#include_test-checkbox')).toBeTruthy()
+
+ await page.waitForSelector('text=README.md')
+ await page.getByText('Training', { exact: true }).click()
+ await page
+ .getByRole('combobox', {
+ name: 'Select the argument parser for training'
+ })
+ .selectOption(`${name}`)
+ await page.check('#deterministic-checkbox')
+ expect(await page.isChecked('#deterministic-checkbox')).toBeTruthy()
+
+ await page.click('text=Handlers')
+
+ await page.check('#save_training-checkbox')
+ expect(await page.isChecked('#save_training-checkbox')).toBeTruthy()
+
+ await page.check('#save_evaluation-checkbox')
+ expect(await page.isChecked('#save_evaluation-checkbox')).toBeTruthy()
+
+ await page.fill('#filename_prefix-input-text', 'training')
+ expect(
+ await page.$eval('#filename_prefix-input-text', (e) => e.value)
+ ).toBe('training')
+
+ await page.fill('#save_every_iters-input-number', '2')
+ expect(
+ await page.$eval('#save_every_iters-input-number', (e) => e.value)
+ ).toBe('2')
+
+ await page.fill('#n_saved-input-number', '2')
+ expect(await page.$eval('#n_saved-input-number', (e) => e.value)).toBe('2')
+
+ await page.check('#terminate_on_nan-checkbox')
+ expect(await page.isChecked('#terminate_on_nan-checkbox')).toBeTruthy()
+
+ await page.fill('#patience-input-number', '2')
+ expect(await page.$eval('#patience-input-number', (e) => e.value)).toBe('2')
+
+ await page.fill('#limit_sec-input-number', '60')
+ expect(await page.$eval('#limit_sec-input-number', (e) => e.value)).toBe(
+ '60'
+ )
+
+ await page.click('text=Loggers')
+ await page.click('text=config.yaml')
+
+ const downloadPromise = await page
+ .waitForEvent('download', { timeout: 2000 })
+ .catch(() => {
+ page.getByRole('button', { name: 'Code' }).click()
+ page.getByRole('button', { name: 'Download Zip' }).click()
+ return page.waitForEvent('download', { timeout: 2000 })
+ })
+ .catch(() => {
+ page.getByRole('button', { name: 'Code' }).click()
+ page.getByRole('button', { name: 'Download Zip' }).click()
+ return page.waitForEvent('download', { timeout: 2000 })
+ })
+ .catch(() => {
+ page.getByRole('button', { name: 'Code' }).click()
+ page.getByRole('button', { name: 'Download Zip' }).click()
+ return page.waitForEvent('download', { timeout: 2000 })
+ })
+ await downloadPromise.saveAs(
+ `./dist-tests/text-classification-all-${name}.zip`
+ )
+ })
+
+ test(`text-classification launch ${name}`, async () => {
+ await page.selectOption('select', 'template-text-classification')
+
+ await page.waitForSelector('text=README.md')
+ await page.getByText('Training', { exact: true }).click()
+
+ await page
+ .getByRole('combobox', {
+ name: 'Select the argument parser for training'
+ })
+ .selectOption(`${name}`)
+ await page.check('#use_dist-checkbox')
+ expect(await page.isChecked('#use_dist-checkbox')).toBeTruthy()
+
+ expect(await page.isChecked('#dist-torchrun-radio')).toBeTruthy()
+
+ await page.click('text=Loggers')
+ await page.click('text=config.yaml')
+
+ const downloadPromise = await page
+ .waitForEvent('download', { timeout: 2000 })
+ .catch(() => {
+ page.getByRole('button', { name: 'Code' }).click()
+ page.getByRole('button', { name: 'Download Zip' }).click()
+ return page.waitForEvent('download', { timeout: 2000 })
+ })
+ .catch(() => {
+ page.getByRole('button', { name: 'Code' }).click()
+ page.getByRole('button', { name: 'Download Zip' }).click()
+ return page.waitForEvent('download', { timeout: 2000 })
+ })
+ .catch(() => {
+ page.getByRole('button', { name: 'Code' }).click()
+ page.getByRole('button', { name: 'Download Zip' }).click()
+ return page.waitForEvent('download', { timeout: 2000 })
+ })
+
+ await downloadPromise.saveAs(
+ `./dist-tests/text-classification-launch-${name}.zip`
+ )
+ })
+
+ test('text-classification spawn', async () => {
+ await page.selectOption('select', 'template-text-classification')
+
+ await page.waitForSelector('text=README.md')
+ await page.getByText('Training', { exact: true }).click()
+ await page
+ .getByRole('combobox', {
+ name: 'Select the argument parser for training'
+ })
+ .selectOption(`${name}`)
+ await page.check('#use_dist-checkbox')
+ expect(await page.isChecked('#use_dist-checkbox')).toBeTruthy()
+
+ await page.check('#dist-spawn-radio')
+ expect(await page.isChecked('#dist-spawn-radio')).toBeTruthy()
+
+ await page.click('text=Loggers')
+ await page.click('text=config.yaml')
+
+ const downloadPromise = await page
+ .waitForEvent('download', { timeout: 2000 })
+ .catch(() => {
+ page.getByRole('button', { name: 'Code' }).click()
+ page.getByRole('button', { name: 'Download Zip' }).click()
+ return page.waitForEvent('download', { timeout: 2000 })
+ })
+ .catch(() => {
+ page.getByRole('button', { name: 'Code' }).click()
+ page.getByRole('button', { name: 'Download Zip' }).click()
+ return page.waitForEvent('download', { timeout: 2000 })
+ })
+ .catch(() => {
+ page.getByRole('button', { name: 'Code' }).click()
+ page.getByRole('button', { name: 'Download Zip' }).click()
+ return page.waitForEvent('download', { timeout: 2000 })
+ })
+ await downloadPromise.saveAs(
+ `./dist-tests/text-classification-spawn-${name}.zip`
+ )
+ })
+}