refactor: extension change to .pyi, add readme and requirements #24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
| Tests are passing on colab, merging |
vfdev-5 reviewed Mar 24, 2021
| @@ -0,0 +1,91 @@ | |||
| # Image Classification Template by Code-Generator | |||
| | |||
| This template is ported from [PyTorch-Ignite MNIST example](https://github.com/pytorch/ignite/blob/master/examples/mnist/mnist.py). | |||
There was a problem hiding this comment.
It is not MNIST but CIFAR10 right ?
There was a problem hiding this comment.
Yep, Thanks for pointing out
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
This PR
README.mdandrequirements.txtto both gan and image classification templates.pyito have syntax highlighting in IDE and on GitHub.sidebar.pyto_sidebar.pynot to confuse with template files.basetemplate to_baseto have some generic reusable jinja template for ignite handlers, loggers, distributed training settings, hydra, ... (common things around templates will go into_base)This PR is more viewable locally as some are
isortandblackformatted.