- Notifications
You must be signed in to change notification settings - Fork 24
Add transformer template: text classification task #19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
849baeb
to ac9b475
Compare ac9b475
to a31b5f6
Compare 586139a
to c76b3c0
Compare c76b3c0
to 903c019
Compare ff87feb
to 1aa6c2d
Compare bc59a95
to 4f3f38b
Compare 4f3f38b
to 275b0a2
Compare Kindly asking for the review @pytorch-ignite/project-leaders ! |
ydcjeff reviewed Apr 19, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @trsvchn. A few comments
vfdev-5 reviewed Apr 19, 2021
vfdev-5 reviewed Apr 19, 2021
trsvchn commented Apr 19, 2021
Co-authored-by: Jeff Yang <32727188+ydcjeff@users.noreply.github.com> Co-authored-by: vfdev <vfdev.5@gmail.com>
vfdev-5 reviewed Apr 19, 2021
vfdev-5 reviewed Apr 19, 2021
vfdev-5 reviewed Apr 19, 2021
vfdev-5 reviewed Apr 19, 2021
vfdev-5 reviewed Apr 19, 2021
vfdev-5 approved these changes Apr 19, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @trsvchn !
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
fix #16
This is a very minimal template. It reproduces transformer example from ignite examples.
I "parameterized" the example as it is, so there is no correspondence with the basic template. On the next step I'll try to fit (if possible) text_cls template to the base config.
In addition, I tried to use a toml for configuration, since it's already available as dependency for streamlit, and, personally, I prefer to use it for configs.