Skip to content

Conversation

trsvchn
Copy link
Member

@trsvchn trsvchn commented Mar 16, 2021

fix #16

This is a very minimal template. It reproduces transformer example from ignite examples.

I "parameterized" the example as it is, so there is no correspondence with the basic template. On the next step I'll try to fit (if possible) text_cls template to the base config.

In addition, I tried to use a toml for configuration, since it's already available as dependency for streamlit, and, personally, I prefer to use it for configs.

@trsvchn trsvchn changed the title Add transformer template [WIP] Add transformer template Mar 16, 2021
@trsvchn trsvchn added this to the v0.1.0 milestone Mar 16, 2021
@trsvchn trsvchn force-pushed the transformers-template branch 2 times, most recently from 849baeb to ac9b475 Compare April 13, 2021 20:31
@trsvchn trsvchn force-pushed the transformers-template branch from ac9b475 to a31b5f6 Compare April 15, 2021 20:53
@trsvchn trsvchn force-pushed the transformers-template branch 2 times, most recently from 586139a to c76b3c0 Compare April 18, 2021 11:28
@trsvchn trsvchn force-pushed the transformers-template branch from c76b3c0 to 903c019 Compare April 18, 2021 11:29
@trsvchn trsvchn force-pushed the transformers-template branch from ff87feb to 1aa6c2d Compare April 18, 2021 11:51
@trsvchn trsvchn force-pushed the transformers-template branch from bc59a95 to 4f3f38b Compare April 18, 2021 18:42
@trsvchn trsvchn force-pushed the transformers-template branch from 4f3f38b to 275b0a2 Compare April 18, 2021 18:44
@trsvchn trsvchn changed the title [WIP] Add transformer template Add transformer template: text classification task Apr 18, 2021
@trsvchn
Copy link
Member Author

trsvchn commented Apr 18, 2021

Kindly asking for the review @pytorch-ignite/project-leaders !

Copy link
Contributor

@ydcjeff ydcjeff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @trsvchn. A few comments

Co-authored-by: Jeff Yang <32727188+ydcjeff@users.noreply.github.com> Co-authored-by: vfdev <vfdev.5@gmail.com>
Copy link
Member

@vfdev-5 vfdev-5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @trsvchn !

@trsvchn trsvchn merged commit 1c112fc into master Apr 19, 2021
@trsvchn trsvchn deleted the transformers-template branch April 19, 2021 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

3 participants