A more accurate termcolor.colored fallback #9435
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
| Eeeeee, I have a strong aversion to mucking about with |
I'll trust your experience on that ! |
Yeah, that sounds fine to me for now :) |
AlexWaygood approved these changes Dec 31, 2022
AlexWaygood changed the title termcolor.colored fallbacktermcolor.colored fallback Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
utils.colored's signature now correctly reflectstermcolor.coloredAttempt in
scripts/runtests.pyto deduplicate the same fallback (using utils module in an outside folder).I think the solution is fine, but you tell me.VSCode can pick-up the source just fine,mypy might need an extramypy_path="tests"to remove# type: ignore[import]at line 13.Edit: Apparently it wasn't a great solution (see comments below)