xml: improve bytes types #9110
Merged
xml: improve bytes types #9110
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
| def data(self, __data: str) -> None: ... | ||
| # tag and attrs are passed to the element_factory, so they could be anything | ||
| # depending on what the particular factory supports. | ||
| def start(self, __tag: Any, __attrs: dict[Any, Any]) -> Element: ... |
Collaborator
There was a problem hiding this comment.
might be worth keeping the comment, but only changing the type if someone actually complains?
Member Author
There was a problem hiding this comment.
The existing type is pretty hard to achieve due to invariance, so I'd rather not keep it.
Co-authored-by: Shantanu <12621235+hauntsaninja@users.noreply.github.com>
hauntsaninja approved these changes Nov 11, 2022
Contributor
| According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
No description provided.