subprocess: Improve bytes-related types #9100
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Member
JelleZijlstra commented Nov 5, 2022
JelleZijlstra commented - subprocess: improve bytes-related types
- replace _TXT alias
This comment has been minimized.
This comment has been minimized.
Member Author
| For the mypy-primer issue, seems like mypy incorrectly picks a specific overload at https://github.com/pytest-dev/pytest/blob/2f33ea87c8d303c3439655eb2bea24483bffde5e/src/_pytest/_py/path.py#L1176. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
JelleZijlstra commented Nov 12, 2022
This comment has been minimized.
This comment has been minimized.
Contributor
| According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
hauntsaninja approved these changes Jan 12, 2023
Collaborator
hauntsaninja left a comment
hauntsaninja left a comment There was a problem hiding this comment.
Lgtm, didn't check for any errors of omission
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.