socketserver: improve bytes handling #9096
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
Member Author
| hm, since these are mostly for subclasses, making the address types precise is probably mostly a hassle for subclassers. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
AlexWaygood requested changes Nov 25, 2022
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
AlexWaygood reviewed Jan 12, 2023
Member
AlexWaygood left a comment
AlexWaygood left a comment There was a problem hiding this comment.
Looks good now, just one more question: Should the BaseServer.server_address attribute (on line 39) also be changed to be _socket._Address, to match the type passed in __init__?
This comment has been minimized.
This comment has been minimized.
AlexWaygood approved these changes Jan 12, 2023
Contributor
| According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
No description provided.