imaplib: fix bytes usage #9021
Merged
imaplib: fix bytes usage #9021
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
stdlib/imaplib.pyi Outdated
| | ||
| def Internaldate2tuple(resp: bytes) -> time.struct_time: ... | ||
| def Internaldate2tuple(resp: ReadableBuffer) -> time.struct_time | None: ... | ||
| def Int2AP(num: int) -> str: ... |
Member
There was a problem hiding this comment.
Suggested change
| def Int2AP(num: int) -> str: ... | |
| def Int2AP(num: int) -> bytes: ... |
Not directly related but this one definitely returns bytes. We could also change the arg type to SupportsAbs I think.
Member Author
There was a problem hiding this comment.
Yes, sure! It is num = int(abs(num)): SupportsAbs[SupportsInt] 😱
Member
There was a problem hiding this comment.
Still got to fix the return type :)
Member
There was a problem hiding this comment.
Yes, sure! It is
num = int(abs(num)):SupportsAbs[SupportsInt]😱
Could be worse:
typeshed/stdlib/unittest/case.pyi
Line 219 in b5c4580
JelleZijlstra approved these changes Oct 28, 2022
Contributor
| According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
sendcalls_socket.sendallappendcallsMapCRLF.sub(CRLF, message)Source: https://github.com/python/cpython/blob/7ee3aca00a0dffc9cb5906a24005a8c61d5bce14/Lib/imaplib.py
Refs #9006