Skip to content

typed-ast: fix get_docstring, allow buffer #9019

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
JelleZijlstra merged 1 commit into from
Oct 28, 2022
Merged

typed-ast: fix get_docstring, allow buffer #9019

JelleZijlstra merged 1 commit into from
Oct 28, 2022

Conversation

@hauntsaninja
Copy link
Collaborator

@hauntsaninja hauntsaninja commented Oct 28, 2022

No description provided.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 28, 2022

According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉
JelleZijlstra
JelleZijlstra approved these changes Oct 28, 2022
View reviewed changes
Copy link
Member

@JelleZijlstra JelleZijlstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!
stubs/typed-ast/typed_ast/ast27.pyi
def dump(node: AST, annotate_fields: bool = ..., include_attributes: bool = ...) -> str: ...
def fix_missing_locations(node: AST) -> AST: ...
def get_docstring(node: AST, clean: bool = ...) -> bytes | None: ...
def get_docstring(node: AST, clean: bool = ...) -> str | bytes | None: ...
Copy link
Member

@JelleZijlstra JelleZijlstra Oct 28, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was confused about how this could be bytes, but then I remembered Python 2.
Copy link
Collaborator Author

@hauntsaninja hauntsaninja Oct 28, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ast27.get_docstring(ast27.parse("""def f(): 'hi'""").body[0]) does crash at runtime (but it works with clean=False)
@JelleZijlstra JelleZijlstra merged commit 7edad95 into python:master Oct 28, 2022
@hauntsaninja hauntsaninja deleted the typed-ast branch October 28, 2022 18:08
@AlexWaygood AlexWaygood mentioned this pull request Oct 28, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants

@hauntsaninja @JelleZijlstra