Skip to content

Conversation

hauntsaninja
Copy link
Collaborator

Partial revert of #4289. Fixes #4313

Copy link
Contributor

@vishalkuo vishalkuo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems fine to me, but not sure if I should be the sole reviewer here?

Copy link
Member

@JelleZijlstra JelleZijlstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feel free to merge once CI passes.

@JelleZijlstra
Copy link
Member

Well I fixed black but now isort is unhappy. I don't have time right now to look for a way to make them agree but might come back to it later.

We should perhaps upgrade to the new isort release that has explicit support for black compatibility.

@hauntsaninja
Copy link
Collaborator Author

isort finally has a new release? That's been a long time coming.
It looks like its averaged a release a day since 5.0.0 (including some highly pertinent fixes like PyCQA/isort#1284), so I can look into this in a week or two.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants