address some more type errors #15114
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
danieleades force-pushed the docutils.2 branch from 0a019a0 to a482367 Compare Contributor
| Diff from mypy_primer, showing the effect of this PR on open source code: sphinx (https://github.com/sphinx-doc/sphinx) + sphinx/transforms/__init__.py: note: In class "SphinxSmartQuotes": + sphinx/transforms/__init__.py:368:5: error: Cannot override instance variable (previously declared on base class "SmartQuotes") with class variable [misc] + sphinx/util/rst.py:69: error: Unused "type: ignore" comment [unused-ignore] + sphinx/util/docutils.py: note: In member "write" of class "SphinxFileOutput": + sphinx/util/docutils.py:456:5: error: Signature of "write" incompatible with supertype "docutils.io.FileOutput" [override] + sphinx/util/docutils.py:456:5: note: Superclass: + sphinx/util/docutils.py:456:5: note: @overload + sphinx/util/docutils.py:456:5: note: def write(self, data: str) -> str | bytes + sphinx/util/docutils.py:456:5: note: @overload + sphinx/util/docutils.py:456:5: note: def write(self, data: bytes) -> bytes + sphinx/util/docutils.py:456:5: note: Subclass: + sphinx/util/docutils.py:456:5: note: def write(self, data: str) -> str + sphinx/util/docutils.py: note: At top level: + sphinx/util/docutils.py:472: error: Unused "type: ignore" comment [unused-ignore] + sphinx/util/docutils.py: note: In member "write" of class "SphinxFileOutput": + sphinx/util/docutils.py:472:16: error: Incompatible return value type (got "str | bytes", expected "str") [return-value] + sphinx/util/docutils.py:472:16: note: Error code "return-value" not covered by "type: ignore" comment + sphinx/directives/__init__.py:333: error: Unused "type: ignore" comment [unused-ignore] |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
based on findings in sphinx-doc/sphinx#13634
should be retested after that PR is merged