Skip to content

Conversation

@srittau
Copy link
Collaborator

srittau commented Nov 19, 2025

As far as I can see, this class was only added in 3.14 "for real". So we need to distinguish between those cases.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@guoci
Copy link
Contributor Author

guoci commented Nov 19, 2025

I need help with resolving the remaining errors

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@guoci
Copy link
Contributor Author

guoci commented Nov 20, 2025

It appears that the attribute name type is causing the error. If I rename it to _type_, it works fine.
See: #15057

@srittau
Copy link
Collaborator

srittau commented Nov 20, 2025

I think it's best to have to complete separate _CField classes, one for 3.14+ and one for < 3.14. This way we can keep the @type_check_only decorator and it could alleviate some of the problems.

@github-actions

This comment has been minimized.

@github-actions
Copy link
Contributor

According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants