Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
for @eugeneliukindev
questions:
notes on things I would like to modify:
FileWrapper.__getitem__is odd, mark the argumentNeverload_classto only classes it is used for viagunicorn.conf.pywrite_errorshall not inject arbitrary str datatimeoutare actually float not int, andgunicorn/workers/sync.pyactually uses thistimeout_ctxmust return a context wrapperThreadWorker.polleris legitimatehandle_request(listener_name)can be either (addr,port) tuples or string (e.g. UNIX sockets)