Skip to content

Conversation

@tomasr8
Copy link
Member

@tomasr8 tomasr8 commented Jul 25, 2024

Closes #2446

I changed the code block color for the closest darker green that surpasses 4.5 - Firefox is now reporting it as 4.57.

I didn't want to change the link color for all links, so I just added a new rule to target links in tables only. Firefox now reports the new value as 4.56.

Let me know if it's ok like this!

@hugovk
Copy link
Member

hugovk commented Jul 25, 2024

I only checked the green so far, looks better.

Before:

image

After:

image

You know, I might be tempted to drop that rounded grey background box altogether, we don't have that sort of thing at https://docs.python.org/3/whatsnew/3.12.html, or keep the grey background but drop the shadow and rounder border radius.

image image

(Possibly also ditching the green?)

image image
@tomasr8
Copy link
Member Author

tomasr8 commented Jul 26, 2024

Could also decrease the padding.. It looks pretty big

@JacobCoffee
Copy link
Member

I think I like this the best out of the options:

image

but the current "After:" state is good, too.

Copy link
Member

@JacobCoffee JacobCoffee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for your first contribution, @tomasr8 :)

@JacobCoffee JacobCoffee changed the title [a11y] Improve low constrast of code blocks and links fix(frontend): Improve low constrast of code blocks and links Sep 16, 2024
@hugovk
Copy link
Member

hugovk commented Nov 7, 2025

Looks like we forgot about this PR :)

I think I like this the best out of the options:

image

Yeah, let's ditch all padding/margin/background/box stuff.

@tomasr8 Please could you update to remove that too?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants