Skip to content

Conversation

mattwang44
Copy link
Collaborator

resolve #902

Details image image image
Copy link
Collaborator

@ken71301 ken71301 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

review p1.

@mattwang44 mattwang44 requested a review from ken71301 June 26, 2024 15:09
@mattwang44 mattwang44 force-pushed the howto/gdb_helpers branch from d261a5c to 06592bb Compare July 4, 2024 09:26
Copy link
Collaborator

@ken71301 ken71301 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

late review p2

"A similar confusion can arise with the ``str`` type, where the output looks "
"a lot like gdb's built-in printer for ``char *``::"
msgstr ""
"``str`` 型別也會出現類似的混亂,其中的輸出看起來很像對於 ``char *`` 的 gdb 內"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

看這樣會不會比較順

Suggested change
"``str`` 型別也會出現類似的混亂,其中的輸出看起來很像對於 ``char *`` 的 gdb 內"
"使用 ``str`` 型別時也會出現類似的困惑,其中的輸出看起來很像對於 ``char *`` 的 gdb 內"
#: ../../howto/gdb_helpers.rst:261
msgid "so we're at the top of the Python stack."
msgstr ""
msgstr "所以我們處於 Python 堆疊的頂端。"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

語意上這邊要不要加個現在,看了一下原文排版,如果只打所以的話好像跟上面的code block連接不太起來
so (now) we're at the top of the Python stack.

#: ../../howto/gdb_helpers.rst:289
msgid "and we're at the bottom of the Python stack."
msgstr ""
msgstr "我們處於 Python 堆疊的底部。"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

一樣看要不要補個 now ,只是因為順暢度

"a specific frame within the selected thread, like this::"
msgstr ""
"擴充命令補充了 GDB 的內建命令。例如,你可以使用 ``py-bt`` 顯示的 frame 編號"
"和 ``frame`` 命令來轉到所選執行緒中的特定 frame ,如下所示: ::"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

這邊的 with the frame command,應該比較接近於 frame 編號會跟 frame 命令一同出現吧?
你可以使用 ``py-bt`` 中與 ``frame`` 命令一同顯示的 frame 編號...
我看原文應該比較像是這樣

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

py-bt 會顯示 frame number,而 GDB 的 frame 則是會跳到給定 frame no 的 frame 上方便查看該 frame。這邊的敘述應該是可以拿這個 py-bt 輸出的 frame no 來和 frame 一起使用。小修一下使其更貼近原意。

image
@mattwang44 mattwang44 requested a review from ken71301 August 26, 2024 17:01
@mattwang44 mattwang44 enabled auto-merge (squash) August 26, 2024 17:03
@mattwang44 mattwang44 disabled auto-merge September 11, 2024 15:52
@mattwang44 mattwang44 merged commit d30872c into python:3.12 Sep 11, 2024
@mattwang44 mattwang44 deleted the howto/gdb_helpers branch September 11, 2024 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants