chore: change scripts to makefile #821
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
| 目前是在 目前測試結果：
|
rockleona force-pushed the chore/makefile-update branch from 988e171 to b8254ce Compare 
rockleona commented Feb 21, 2024
| . $(VENV_FOR_SCRIPT)/bin/activate; \ | ||
| python3 google_translate/main.py $(_file_path) > $(_tmp_po_file) ; \ | ||
| pomerge -t $(_file_path) -i $(_tmp_po_file) -o $(_file_path) ; \ | ||
| # rm $(_tmp_po_file) |
There was a problem hiding this comment.
被我註解起來的這一行會有下列錯誤
/bin/sh: 4: : not found make: *** [Makefile:100：google_translate] 錯誤 127 完全不知道錯誤在哪裡＠＠，再麻煩好心人協助
mattwang44 reviewed Feb 21, 2024
There was a problem hiding this comment.
原本有 pyproject.toml，不延用 poetry 嗎？
There was a problem hiding this comment.
我想說跟 makefile 完美結合的話，應該是改成 venv + pip 做管理；
但對，沿用的話會簡單很多（嗎？）
There was a problem hiding this comment.
poetry 也有能力去建立與管理 virtual environment
- https://python-poetry.org/docs/basic-usage/#activating-the-virtual-environment
- https://python-poetry.org/docs/managing-environments/
python package tools
There was a problem hiding this comment.
沿用不一定比較好寫，畢竟現在比較像是 follow makefile 現有的寫法，所以不太會有 survey 的成分。
只是我就沒有覺得哪個跟 makefile 會比較能夠完美結合。
There was a problem hiding this comment.
poetry 也有能力去建立與管理 virtual environment
- https://python-poetry.org/docs/basic-usage/#activating-the-virtual-environment
- https://python-poetry.org/docs/managing-environments/
python package tools
原來根本的原因是因為我不熟QQ，我來研究一下怎麼做
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
關於之前寫 script 的時候，來自 @mattwang44 的願望 (?)
也感謝 #643 方格子跟 Josix 的寫法參考，第一次寫 Makefile 再麻煩大家提供建議了