Skip to content

Conversation

@mindihx
Copy link
Collaborator

@mindihx mindihx commented Aug 6, 2023

昨天 meetup 有 comment 要多翻譯一段,後來回家把它完成了。
因為內容有很多格式所以附上 compile 出來的 html 方便 review
json.zip

@mattwang44
Copy link
Collaborator

mattwang44 commented Aug 6, 2023

感謝幫忙!稍晚再 review
Preview 部分之後可以直接在 local 上打開再截圖放在 PR description 就好~

library/json.po Outdated
Comment on lines 40 to 44
"換格式,在 :rfc:`7159`\ (其廢棄了 :rfc:`4627`\ )及 `ECMA-404 <https://"
"www.ecma-international.org/publications-and-standards/standards/ecma-404/>`_ "
"裡面有詳細說明,它啟發自 `JavaScript <https://en.wikipedia.org/wiki/"
"JavaScript>`_ 的物件字面語法 (object literal syntax)(雖然它並不是 "
"JavaScript 的嚴格子集 [#rfc-errata]_\ )。"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

翻譯與語法我覺得都很精準!

但 project 中關於反斜線做 space escaping 的用法有個不成文小規定:escaping 的確是單個反斜線就能生效 (ref),但是單個反斜線在 poedit 等常見編輯器中又必須要做 escaping,所以 project 內都是使用兩個反斜線。

Suggested change
"換格式,在 :rfc:`7159`\ (其廢棄了 :rfc:`4627`\ )及 `ECMA-404 <https://"
"www.ecma-international.org/publications-and-standards/standards/ecma-404/>`_ "
"裡面有詳細說明,它啟發自 `JavaScript <https://en.wikipedia.org/wiki/"
"JavaScript>`_ 的物件字面語法 (object literal syntax)(雖然它並不是 "
"JavaScript 的嚴格子集 [#rfc-errata]_\ )。"
"換格式,在 :rfc:`7159`\\ (其廢棄了 :rfc:`4627`\\ )及 `ECMA-404 <https://"
"www.ecma-international.org/publications-and-standards/standards/ecma-404/>`_ "
"裡面有詳細說明,它啟發自 `JavaScript <https://en.wikipedia.org/wiki/"
"JavaScript>`_ 的物件字面語法 (object literal syntax)(雖然它並不是 "
"JavaScript 的嚴格子集 [#rfc-errata]_\\ )。"
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

已修正,謝謝
建議 README 裡面也可以調整一下說明~
https://github.com/python/python-docs-zh-tw#rst-%E8%AA%9E%E6%B3%95%E6%B3%A8%E6%84%8F%E4%BA%8B%E9%A0%85

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

建議 README 裡面也可以調整一下說明

OK!

@mattwang44 mattwang44 changed the base branch from 3.12 to aug-5-meetup August 7, 2023 02:20
Copy link
Collaborator

@mattwang44 mattwang44 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for the efforts!

@mattwang44 mattwang44 merged commit f97e54f into python:aug-5-meetup Aug 7, 2023
mattwang44 pushed a commit that referenced this pull request Aug 14, 2023
* Add translation for library/json * Fix using single backslash to escape space
mattwang44 added a commit that referenced this pull request Aug 14, 2023
* /library/datetime.rst:2485 (#549) * Translate datetime.rst:754 (#548) * datetime.rst:754 * Apply suggestions from code review * translate datetime.rst:196 (#545) * git commit rst:157 translate (#535) * feat(translate): json.po line 323 to tranditional chinese (#532) * Datetime/upstream/3.12 (#550) * translate-datetime.rst:2369 * datetime-2369-fixed-by-reviewer --------- Co-authored-by: Dai Stella <daistella@DaiMacAirM2.local> Co-authored-by: Wei-Hsiang (Matt) Wang <mattwang44@gmail.com> * translate `library/datetime.rst:2619` (#524) * docs: translate footnote 1 * fix: translate msg * fix: translate of Relativity * Add translations to `library/json` rst:26 and rst:29 (#537) * Add translations to `library/json` rst:26 and rst:29 * fix literal code block marker * Update library/json.po Co-authored-by: RockLeon <34214497+rockleona@users.noreply.github.com> --------- Co-authored-by: RockLeon <34214497+rockleona@users.noreply.github.com> * translate json title (#523) * Add translation for library/json (#555) * Add translation for library/json * Fix using single backslash to escape space * Translate library/datetime.rst:124 (#543) * Translate library/datetime.rst:124 * Apply suggestions from code review Co-authored-by: RockLeon <34214497+rockleona@users.noreply.github.com> * Update datetime.po * Update datetime.po --------- Co-authored-by: RockLeon <34214497+rockleona@users.noreply.github.com> * Add translation for library/json (#527) * Add translation for library/json * Refine sentence in library/json * 📝 docs(3.12): translate library/json.rst:63 (#542) * 📝 docs(3.12): translate library/json.rst:63 for procedure test purpose, translate /library/json.rst:63 * 📝 docs(3.12): translate library/json.rst:63 通順語句與空格修正 * 📝 docs(3.12): translate library/json.rst:63 fix rst issue --------- Co-authored-by: 鄭宇辰 <ken71301@gmail.com> Co-authored-by: Wei-Hsiang (Matt) Wang <mattwang44@gmail.com> * Translate library/datetime.rst:2501 (#526) * Translate library/datetime.rst:2501 * Translate library/datetime.rst:2501, remove spaces * Update library/datetime.rst:2501, punctuation mark * Update library/datetime.rst:2501, 'format code' * Update library/datetime.rst:2505 --------- Co-authored-by: Wei-Hsiang (Matt) Wang <mattwang44@gmail.com> * Translated the weekday sentence (#534) * Translated the weekday sentence * Modified the error * Update library/datetime.po --------- Co-authored-by: 李逸帆 <ivan@liyifande-MacBook-Pro.local> Co-authored-by: Wei-Hsiang (Matt) Wang <mattwang44@gmail.com> * Translate datetime rst: 709 (#539) * Translate datetime rst: 709 * Update library/datetime.po --------- Co-authored-by: Wei-Hsiang (Matt) Wang <mattwang44@gmail.com> * translate datetime.rst:872 (#540) * translate datetime.rst:872 * Update library/datetime.po --------- Co-authored-by: Wei-Hsiang (Matt) Wang <mattwang44@gmail.com> * translated 'check reference' is Falses841u0 (#525) * translated 'check reference' is Falses841u0 * 依建議改為將'視為'改為'設為' * Update library/json.po --------- Co-authored-by: Wei-Hsiang (Matt) Wang <mattwang44@gmail.com> * New branch2 (#544) * git commit rst:157 translate * 改rst:179 * Update library/datetime.po --------- Co-authored-by: Wei-Hsiang (Matt) Wang <mattwang44@gmail.com> --------- Co-authored-by: isabellechiu <39623214+isabellechiu@users.noreply.github.com> Co-authored-by: Song-Lin Tsai <55531306+Bradley-Tsai@users.noreply.github.com> Co-authored-by: ccchian <72912233+ccchian@users.noreply.github.com> Co-authored-by: neo <71454430+neo-maker-sudo@users.noreply.github.com> Co-authored-by: ai.Stella <63219262+estelladai@users.noreply.github.com> Co-authored-by: Dai Stella <daistella@DaiMacAirM2.local> Co-authored-by: Simon Chu <chicochu9333@gmail.com> Co-authored-by: Yu-Sheng Li <kevin1kevin1k@gmail.com> Co-authored-by: RockLeon <34214497+rockleona@users.noreply.github.com> Co-authored-by: mindihx <ymhuang.ymh@gmail.com> Co-authored-by: 933yee <92087014+933yee@users.noreply.github.com> Co-authored-by: Payon <ken71301@hotmail.com> Co-authored-by: 鄭宇辰 <ken71301@gmail.com> Co-authored-by: Griiid <gridwing@gmail.com> Co-authored-by: Ivan Lee <leeivan1007@gmail.com> Co-authored-by: 李逸帆 <ivan@liyifande-MacBook-Pro.local> Co-authored-by: Yang_yang <31895597+Yang92047111@users.noreply.github.com> Co-authored-by: PinErh Chen <chanpiner518@gmail.com> Co-authored-by: Nick (Shun-Fu) Hu <husohome98@gmail.com>
beccalzh pushed a commit to beccalzh/python-docs-zh-tw that referenced this pull request Sep 4, 2024
* /library/datetime.rst:2485 (python#549) * Translate datetime.rst:754 (python#548) * datetime.rst:754 * Apply suggestions from code review * translate datetime.rst:196 (python#545) * git commit rst:157 translate (python#535) * feat(translate): json.po line 323 to tranditional chinese (python#532) * Datetime/upstream/3.12 (python#550) * translate-datetime.rst:2369 * datetime-2369-fixed-by-reviewer --------- Co-authored-by: Dai Stella <daistella@DaiMacAirM2.local> Co-authored-by: Wei-Hsiang (Matt) Wang <mattwang44@gmail.com> * translate `library/datetime.rst:2619` (python#524) * docs: translate footnote 1 * fix: translate msg * fix: translate of Relativity * Add translations to `library/json` rst:26 and rst:29 (python#537) * Add translations to `library/json` rst:26 and rst:29 * fix literal code block marker * Update library/json.po Co-authored-by: RockLeon <34214497+rockleona@users.noreply.github.com> --------- Co-authored-by: RockLeon <34214497+rockleona@users.noreply.github.com> * translate json title (python#523) * Add translation for library/json (python#555) * Add translation for library/json * Fix using single backslash to escape space * Translate library/datetime.rst:124 (python#543) * Translate library/datetime.rst:124 * Apply suggestions from code review Co-authored-by: RockLeon <34214497+rockleona@users.noreply.github.com> * Update datetime.po * Update datetime.po --------- Co-authored-by: RockLeon <34214497+rockleona@users.noreply.github.com> * Add translation for library/json (python#527) * Add translation for library/json * Refine sentence in library/json * 📝 docs(3.12): translate library/json.rst:63 (python#542) * 📝 docs(3.12): translate library/json.rst:63 for procedure test purpose, translate /library/json.rst:63 * 📝 docs(3.12): translate library/json.rst:63 通順語句與空格修正 * 📝 docs(3.12): translate library/json.rst:63 fix rst issue --------- Co-authored-by: 鄭宇辰 <ken71301@gmail.com> Co-authored-by: Wei-Hsiang (Matt) Wang <mattwang44@gmail.com> * Translate library/datetime.rst:2501 (python#526) * Translate library/datetime.rst:2501 * Translate library/datetime.rst:2501, remove spaces * Update library/datetime.rst:2501, punctuation mark * Update library/datetime.rst:2501, 'format code' * Update library/datetime.rst:2505 --------- Co-authored-by: Wei-Hsiang (Matt) Wang <mattwang44@gmail.com> * Translated the weekday sentence (python#534) * Translated the weekday sentence * Modified the error * Update library/datetime.po --------- Co-authored-by: 李逸帆 <ivan@liyifande-MacBook-Pro.local> Co-authored-by: Wei-Hsiang (Matt) Wang <mattwang44@gmail.com> * Translate datetime rst: 709 (python#539) * Translate datetime rst: 709 * Update library/datetime.po --------- Co-authored-by: Wei-Hsiang (Matt) Wang <mattwang44@gmail.com> * translate datetime.rst:872 (python#540) * translate datetime.rst:872 * Update library/datetime.po --------- Co-authored-by: Wei-Hsiang (Matt) Wang <mattwang44@gmail.com> * translated 'check reference' is Falses841u0 (python#525) * translated 'check reference' is Falses841u0 * 依建議改為將'視為'改為'設為' * Update library/json.po --------- Co-authored-by: Wei-Hsiang (Matt) Wang <mattwang44@gmail.com> * New branch2 (python#544) * git commit rst:157 translate * 改rst:179 * Update library/datetime.po --------- Co-authored-by: Wei-Hsiang (Matt) Wang <mattwang44@gmail.com> --------- Co-authored-by: isabellechiu <39623214+isabellechiu@users.noreply.github.com> Co-authored-by: Song-Lin Tsai <55531306+Bradley-Tsai@users.noreply.github.com> Co-authored-by: ccchian <72912233+ccchian@users.noreply.github.com> Co-authored-by: neo <71454430+neo-maker-sudo@users.noreply.github.com> Co-authored-by: ai.Stella <63219262+estelladai@users.noreply.github.com> Co-authored-by: Dai Stella <daistella@DaiMacAirM2.local> Co-authored-by: Simon Chu <chicochu9333@gmail.com> Co-authored-by: Yu-Sheng Li <kevin1kevin1k@gmail.com> Co-authored-by: RockLeon <34214497+rockleona@users.noreply.github.com> Co-authored-by: mindihx <ymhuang.ymh@gmail.com> Co-authored-by: 933yee <92087014+933yee@users.noreply.github.com> Co-authored-by: Payon <ken71301@hotmail.com> Co-authored-by: 鄭宇辰 <ken71301@gmail.com> Co-authored-by: Griiid <gridwing@gmail.com> Co-authored-by: Ivan Lee <leeivan1007@gmail.com> Co-authored-by: 李逸帆 <ivan@liyifande-MacBook-Pro.local> Co-authored-by: Yang_yang <31895597+Yang92047111@users.noreply.github.com> Co-authored-by: PinErh Chen <chanpiner518@gmail.com> Co-authored-by: Nick (Shun-Fu) Hu <husohome98@gmail.com>
@mindihx mindihx deleted the translate-json-spec branch September 11, 2024 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants