Skip to content

Conversation

mattwang44
Copy link
Collaborator

@mattwang44 mattwang44 commented Jan 19, 2022

resolve #200

preview:

image

@mattwang44
Copy link
Collaborator Author

@StevenHsuYL 想請問大大有興趣來幫忙 review PR 嗎?

c-api/call.po Outdated
"callable. The signature of the slot is::"
msgstr ""
"設定 :c:member:`~PyTypeObject.tp_call` 的類別之實例都是可呼叫的。槽位 (slot) "
"的簽名為:\n"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"The signature of the slot is"
我的理解是 "該擴充槽 (slot) 的用法如下:"

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

我還是傾向要把 signature 一詞翻譯出來,有什麼原因覺得應該要改成「用法」嗎?

Copy link
Contributor

@StevenHsuYL StevenHsuYL Jun 11, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

這邊應該是我比較不了解 function signature 這個概念,抱歉造成困擾。
看完 wiki 後,我覺得也可以考慮 "該擴充槽 (slot) 的簽章為:"
slot 的來源: slot

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

已改:

  • slot: 槽位 -> 擴充槽
  • signature: 簽名 -> 簽章
Co-authored-by: Steven Hsu <hsuhaochun@gmail.com>
c-api/call.po Outdated
msgstr ""
"類別可以透過啟用 :const:`Py_TPFLAGS_HAVE_VECTORCALL` 旗標並將 :c:member:"
"`~PyTypeObject.tp_vectorcall_offset` 設定為物件結構中有出現 *vectorcallfunc* "
"的 offset 來實現 vectorcall 協定。這是一個指向具有以下簽名之函式的指標:"
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mattwang44 mattwang44 requested a review from StevenHsuYL June 11, 2022 10:25
c-api/call.po Outdated
"are provided."
msgstr ""
"呼叫一個可呼叫的 Python 物件 *callable*,附帶數量可變的 C 引數。這些 C 引數使"
"用 :c:func:`Py_BuildValue` 風格的格式字串來描述。形式可以為 *NULL*,表示沒有"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"用 :c:func:`Py_BuildValue` 風格的格式字串來描述。形式可以為 *NULL*,表示沒有"
"用 :c:func:`Py_BuildValue` 風格的格式字串來描述。format 可以為 *NULL*,表示沒有"

不知道此處的 format 是不是維持原文比較易懂(是指上面程式碼的 format)?

Copy link
Collaborator Author

@mattwang44 mattwang44 Jun 12, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

覺得還是要翻,但我發現我有「形式」、「格式」混用的情況,改成統一使用「格式」

c-api/call.po Outdated
#: ../../c-api/call.rst:291
msgid "The format can be *NULL*, indicating that no arguments are provided."
msgstr ""
msgstr "形式可以為 *NULL*,表示沒有提供任何引數。"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
msgstr "形式可以為 *NULL*,表示沒有提供任何引數。"
msgstr "format 可以為 *NULL*,表示沒有提供任何引數。"
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

如上所述,改成「格式」

@StevenHsuYL
Copy link
Contributor

除了 line 4 和 311 的 "槽位" 來源需要再確認之外,其他都沒問題了!
review 建議參考即可,如果要維持原翻譯也沒關係,重點是看完就可以上傳了! ^^"

ezio-melotti
ezio-melotti previously approved these changes Jun 11, 2022
Co-authored-by: Steven Hsu <hsuhaochun@gmail.com>
@mattwang44
Copy link
Collaborator Author

感謝兩位幫忙 review 🙏🏽🙏🏽🙏🏽
那我修正完就會直接 merge PR

@StevenHsuYL
Copy link
Contributor

LGTM! 👍

@mattwang44 mattwang44 merged commit 565fd29 into python:3.10 Jun 12, 2022
@mattwang44 mattwang44 deleted the capi/call branch June 12, 2022 07:29
beccalzh pushed a commit to beccalzh/python-docs-zh-tw that referenced this pull request Sep 4, 2024
* translate `c-api/call.po` * Apply suggestions from code review Co-authored-by: Steven Hsu <hsuhaochun@gmail.com> * Apply suggestions from code review Co-authored-by: Steven Hsu <hsuhaochun@gmail.com> Co-authored-by: Steven Hsu <hsuhaochun@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants