Skip to content

Conversation

mattwang44
Copy link
Collaborator

@mattwang44 mattwang44 commented Dec 18, 2021

resolve #185

preview:
image

@mattwang44 mattwang44 force-pushed the trans-library-tempfile branch 4 times, most recently from af686ac to c5b8313 Compare December 18, 2021 08:45
@mattwang44
Copy link
Collaborator Author

@allen91wu, would you like to review this PR? (trying to slow your pace 😏)

@allen91wu allen91wu self-requested a review December 19, 2021 16:15
@mattwang44 mattwang44 force-pushed the trans-library-tempfile branch from c5b8313 to 4af3ed8 Compare March 1, 2022 01:49
@mattwang44 mattwang44 force-pushed the trans-library-tempfile branch from 4af3ed8 to 0a07591 Compare March 1, 2022 01:51
@mattwang44
Copy link
Collaborator Author

@allen91wu
Is there any chance you can finish reviewing this PR recently? Or should I assign it to another reviewer?

@mattwang44 mattwang44 removed the request for review from allen91wu March 30, 2022 12:18
@mattwang44 mattwang44 requested a review from ccwang002 June 11, 2022 10:25
@mattwang44 mattwang44 force-pushed the trans-library-tempfile branch from 2686544 to ecb5f5c Compare June 11, 2022 10:35
@mattwang44 mattwang44 force-pushed the trans-library-tempfile branch from ecb5f5c to 372e87a Compare June 11, 2022 10:38
Copy link
Collaborator

@ccwang002 ccwang002 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

我列了一些我覺得有點不順的詞句,你看看要不要修改。其餘部份都 ok 👍

msgstr ""
"回傳一個可當作臨時儲存區域的 :term:`file-like object`\\ 。建立該檔案使用了"
"與 :func:`mkstemp` 相同的安全規則。它將在關閉(包括當物件被垃圾回收 (garbage "
"collect) 時所關閉)後立即銷毀。在 Unix 下,該檔案在目錄中的條目可能根本不被建"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

「被垃圾回收…時所關閉」沒有翻到 implicit,可以改成「被垃圾回收…時的隱式關閉」

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

「該檔案在目錄中的條目可能根本不被建立」這句的意思是不是「該檔案所在的目錄可能根本不被建立」?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

對,原譯文不夠精確

"file (as would be returned by :func:`os.open`) and the absolute pathname of "
"that file, in that order."
msgstr ""
":func:`mkstemp` 回傳一個 tuple,tuple 中,第一個元素是一個作業系統層級 (OS-"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

不確定「OS-level handle」是否翻成「作業系統層級控制程式」

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

原譯文是錯誤的,原本以為是 handler 所以翻成「控制程式」,但這邊的 handle 其實就是一個數字代號,改成「控制代碼」

@mattwang44 mattwang44 force-pushed the trans-library-tempfile branch 2 times, most recently from 4e1733f to a712e4b Compare June 12, 2022 07:15
Co-authored-by: Liang-Bo Wang <me@liang2.tw>
@mattwang44 mattwang44 force-pushed the trans-library-tempfile branch from a712e4b to c17dcda Compare June 12, 2022 07:17
@mattwang44 mattwang44 requested a review from ccwang002 June 12, 2022 07:18
Copy link
Collaborator

@ccwang002 ccwang002 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 辛苦啦~

@mattwang44 mattwang44 merged commit 70f8c49 into python:3.10 Jun 12, 2022
@mattwang44 mattwang44 deleted the trans-library-tempfile branch June 12, 2022 13:27
beccalzh pushed a commit to beccalzh/python-docs-zh-tw that referenced this pull request Sep 4, 2024
* feat: translate `library/tempfile.po` * fix(library/tempfile): remove redundant `\\` * Apply suggestions from code review Co-authored-by: Liang-Bo Wang <me@liang2.tw> Co-authored-by: Liang-Bo Wang <me@liang2.tw>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants