Improve Makefile and workflow #25
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Use JulienPalard and seluj78's pomerge tool to merge translations from current branch with older branches, making it possible to keep documentations of older versions of Python up-to-date with latest translations. workflow: add pomerge step Makefile: add 'merge' target requirements: add pomerge to be installed by pip
Instead of changing dir to OLDPWD in an incorrect way, now using mkdir and sed to create .tx/config
Add @ to the beginning of the command lines to avoid echoing them, and add messages of what is being executed.
Reorganize variables, adding documentation to them
Doing shallow clone (--depth 1) didn't make possible to checkout other branches of CPython, which could be useful for using this script in other branches at some point, e.g. building Python docs.
Now going to use latest python version (3.8)
- Rename workflow name to 'python-docs-pt-br CI', as it makes more sense than the generic 'Build and update documentation' - Separate jobs: rename main workflow from build to 'update'; and move 'merge', 'spell' and 'build' (warnings as errors) into separate jobs, called right next 'update' is done - Simplify 'run' calls, reducing 'name' and '--version' print (log file already has the version installed) - Remove pip-install-log artifact uploading, as the script does not generate this log anymore. - The 'build-warn-as-err' job create an artifact containing log files if job has failed
| See how the workflow would be logged: https://github.com/rffontenelle/python-docs-pt-br/actions/runs/101515431 |
| I liked the previous name for the workflow. This is an example of a badge we can add to the README.md page:
I think a name a bit more explicit would be better, your call though :) |
rougeth approved these changes May 11, 2020
| No problem, I can change back to |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Makefile:
pomergeto merge translations from 3.8 to older branchestx-configof incorrect use of OLDPWD variable--no-single-branchto allow checkout of other branchesWorkflow:
python-versionfromstrategy,matrixactions/setup-pythonandactions/upload-artifactactions to version 2buildjob into mainupdate(most actions) and secondary_merge,spellcheckandbuild-warn-as-errto reduce the size of the output log and to make it easier to read itpython-docs-pt-br CI