Fix function to get if pyperformance is installed in editable mode #369
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
This is used in compile.py: compile_all installs pyperformance for every version it compiles. If the main pyperformance is installed in editable mode, this should be propagated down. The mechamism to do that was broken because was checking the presence of setup.py, now long gone.
mdboom approved these changes Nov 20, 2024
There was a problem hiding this comment.
LGTM, but someone who has used it in this mode more than I have should probably also weigh in ... (@ericsnowcurrently, @vstinner...?)
| I don't recall enough about this to be useful. I'm sure Diego's fix is okay. |
Yes, this is one of the thing that is useful only if you use a specific feature of the tool. @mdboom keeps saying that they don't use the Thanks for approving. |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
This is used in
compile.py:compile_allinstalls pyperformance for every version it compiles. If the main pyperformance is installed in editable mode, this should be propagated down.The mechamism to do that was broken because was checking the presence of
setup.py, now long gone.