Skip to content

Conversation

@mhsmith
Copy link
Member

@mhsmith mhsmith commented Sep 20, 2024

The Android x86_64 buildbot is not yet up and running, so this is not quite ready to be merged. The aarch64 and x86_64 buildbots are both now stable.

@freakboy3742: I assume you're OK with being added as a second core team contact for Android?


📚 Documentation preview 📚: https://pep-previews--3982.org.readthedocs.build/

Copy link
Contributor

@freakboy3742 freakboy3742 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirming that yes - I'm OK being added as a contact for Android platform support.

One other comment inline.

Copy link
Member

@CAM-Gerlach CAM-Gerlach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for being thorough here! There is a small changed needed to fix the intersphinx links to the canonical doc; it should be straightforward but I can commit it for you if you like.

@mhsmith mhsmith changed the title PEP 738: Mark Final, and add Android to PEP 11 PEP 738: Mark Final Sep 23, 2024
@mhsmith mhsmith mentioned this pull request Sep 23, 2024
4 tasks
@AA-Turner AA-Turner changed the title PEP 738: Mark Final PEP 738: Mark as Final Oct 1, 2024
@AA-Turner
Copy link
Member

AA-Turner commented Oct 1, 2024

@mhsmith is there anything outstanding on this PR? [Edit: waiting for 3.13.0 final release for the using-android target to work]

A

@mhsmith
Copy link
Member Author

mhsmith commented Oct 1, 2024

@AA-Turner changed the title PEP 738: Mark Final PEP 738: Mark as Final

You might want to update the title instructions in the PR template.

Copy link
Contributor

@willingc willingc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mhsmith. Do you want to take this PR out of draft mode?

@mhsmith mhsmith marked this pull request as ready for review October 2, 2024 21:09
@mhsmith mhsmith requested a review from encukou as a code owner October 2, 2024 21:09
@hugovk
Copy link
Member

hugovk commented Oct 7, 2024

3.13.0 final is out! https://discuss.python.org/t/python-3-13-0-final-has-been-released/66972

https://docs.python.org/3/ is now 3.13!

I've restarted the CI but it says:

/home/runner/work/peps/peps/peps/pep-0738.rst:12: WARNING: undefined label: 'python:using-android' [ref.ref] 
@AA-Turner
Copy link
Member

I purged https://docs.python.org/3/objects.inv and re-ran again but still failing...

The targets are there in objects.inv, though:

python -m sphinx.ext.intersphinx https://docs.python.org/3/objects.inv | rg android py:attribute test.support.is_android : library/test.html#test.support.is_android py:function platform.android_ver : library/platform.html#platform.android_ver sys.getandroidapilevel : library/sys.html#sys.getandroidapilevel std:doc using/android Using Python on Android : using/android.html std:label using-android Using Python on Android : using/android.html#using-android 
@AA-Turner AA-Turner merged commit dbb5594 into python:main Oct 7, 2024
@hugovk hugovk mentioned this pull request Oct 7, 2024
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

6 participants