Skip to content

Invalidate cache when a plugin is added/removed #5892

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 14, 2018
Merged

Invalidate cache when a plugin is added/removed #5892

merged 1 commit into from
Nov 14, 2018

Conversation

ilevkivskyi
Copy link
Member

#5878 added cache invalidation for situations where a plugin version/hash changes but there is even simpler scenario -- if plugins option itself change, the cache should be invalidated as well.
gvanrossum
gvanrossum approved these changes Nov 14, 2018
View reviewed changes
Copy link
Member

@gvanrossum gvanrossum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a long test for such a small change...
@ilevkivskyi
Copy link
Member Author

It is indeed long, but it is better to be on the safe side.
@ilevkivskyi ilevkivskyi merged commit af4e0b0 into python:master Nov 14, 2018
@ilevkivskyi ilevkivskyi deleted the plugins-affect-cache branch November 14, 2018 04:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants

@ilevkivskyi @gvanrossum