[mypyc] feat: implement try_getting_literal in preallocate helper [1/1] #19979
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
BobTheBuidler changed the title 
BobTheBuidler commented Oct 2, 2025
| else TupleGet(sequence, i, line) | ||
| ) | ||
| for i, typ in enumerate(get_proper_types(proper_type.items)) | ||
| for i, typ in enumerate(map(try_getting_literal, proper_type.items)) |
There was a problem hiding this comment.
On second thought, I'm thinking this maybe this optimization should be a native part of TupleGet?
BobTheBuidler force-pushed the patch-11 branch from bb35146 to b537bc5 Compare 
During the rtuple boxing stage, if any of the values are a known Literal type we can skip the struct access and just load the static literal
BobTheBuidler force-pushed the patch-11 branch from b537bc5 to c8d6cde Compare Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
During the rtuple boxing stage, if any of the values are a known Literal type we can skip the struct access and just load the static literal. I had already tried doing this before but I don't think it was implemented robustly, this improves the identification of Literal types