Fix mypyc failing to compile on CPython 3.10.0a6 #10202
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
21 tasks
_PyObject_HasAttrId() has been removed in python/cpython#22629
We could potentionally already use _PyObject_LookupAttrId starting with python 3.7 instead of 3.10. I'm not sure if we should switch as soon or as late as possible. Alternatively we could also try backporting _PyObject_LookupAttrId to <3.7.
freundTech force-pushed the fix-mypyc-python310 branch from 217b0c1 to 0b94195 Compare 
| I just rebased this to take advantage of the CI run against python nightly. Impact on python nightly: |
sthagen added a commit to sthagen/python-mypy that referenced this pull request Mar 17, 2021
Fix mypyc failing to compile on CPython 3.10.0a6 (python#10202)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Description
_PyObject_HasAttrId() has been removed in python/cpython#22629
Test Plan
Multiple test which failed on 3.10.0a6 are now working again.
All tests still work on python 3.9. mypyc-extra was also tested.