Skip to content

Fix strconv not displaying False and possibly other falsy values #10196

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 10, 2021
Merged

Fix strconv not displaying False and possibly other falsy values #10196

merged 1 commit into from
Mar 10, 2021

Conversation

@freundTech
Copy link
Contributor

@freundTech freundTech commented Mar 10, 2021

Description

This fixes strconv not displaying False and possibly other falsy values. I ran into this problem while writing tests for #10191.

Test Plan

No currently existing tests are affected by this change.
JukkaL
JukkaL approved these changes Mar 10, 2021
View reviewed changes
Copy link
Collaborator

@JukkaL JukkaL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
@JukkaL JukkaL merged commit f0a2c9f into python:master Mar 10, 2021
@freundTech freundTech deleted the fix-strconv-falsy branch March 13, 2021 08:31
@freundTech freundTech mentioned this pull request Oct 20, 2021
Merged
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants

@freundTech @JukkaL