Skip to content

gh-99894: Ensure the local names don't collide with the test file in traceback suggestion error checking #99895

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Dec 1, 2022
Merged

gh-99894: Ensure the local names don't collide with the test file in traceback suggestion error checking #99895

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
5612e56
gh-99894: Ensure the local names don't collide with the test file in …
pablogsal Nov 30, 2022
d159ac5
fixup! gh-99894: Ensure the local names don't collide with the test f…
pablogsal Nov 30, 2022
2287142
Update Lib/test/test_traceback.py
vstinner Nov 30, 2022
227b315
Update Lib/test/test_traceback.py
vstinner Nov 30, 2022
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions Lib/test/test_traceback.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2978,9 +2978,9 @@ class MyClass:
for name in ("b", "v", "m", "py"):
with self.subTest(name=name):
actual = self.get_suggestion(MyClass, name)
self.assertNotIn("you mean", actual)
self.assertNotIn("vvv", actual)
self.assertNotIn("mom", actual)
self.assertNotIn("Did you mean", actual)
self.assertNotIn("'vvv", actual)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know if this has any effect but there is a ' missing here
self.assertNotIn("'mom'", actual)
self.assertNotIn("'id'", actual)
self.assertNotIn("'w'", actual)
self.assertNotIn("'pytho'", actual)
Expand Down Expand Up @@ -3168,9 +3168,9 @@ def test_import_from_error_bad_suggestions_do_not_trigger_for_small_names(self):
for name in ("b", "v", "m", "py"):
with self.subTest(name=name):
actual = self.get_import_from_suggestion(code, name)
self.assertNotIn("you mean", actual)
self.assertNotIn("vvv", actual)
self.assertNotIn("mom", actual)
self.assertNotIn("Did you mean", actual)
self.assertNotIn("'vvv'", actual)
self.assertNotIn("'mom'", actual)
self.assertNotIn("'id'", actual)
self.assertNotIn("'w'", actual)
self.assertNotIn("'pytho'", actual)
Expand Down