Skip to content

GH-94597: add deprecation warnings for subclassing AbstractChildWatcher #99386

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 12, 2022
Merged

GH-94597: add deprecation warnings for subclassing AbstractChildWatcher #99386

merged 3 commits into from
Nov 12, 2022

Conversation

kumaraditya303
Copy link
Contributor

@kumaraditya303 kumaraditya303 commented Nov 11, 2022 •
edited by bedevere-bot
Loading

@bedevere-bot bedevere-bot mentioned this pull request Nov 11, 2022
Closed
@kumaraditya303
Copy link
Contributor Author

kumaraditya303 commented Nov 11, 2022 •
edited
Loading

This isn't really needed as deprecation warning will be emitted anyway when configuring the child watcher via set_child_watcher but still adding for anyone who is subclassing this but not configuring the child watcher for whatever reason.
@kumaraditya303 kumaraditya303 mentioned this pull request Nov 11, 2022
Closed
gvanrossum
gvanrossum approved these changes Nov 11, 2022
View reviewed changes
Copy link
Member

@gvanrossum gvanrossum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(Do double check the appearance of the deprecation note.)
@gvanrossum gvanrossum merged commit aa87432 into python:main Nov 12, 2022
@kumaraditya303 kumaraditya303 deleted the async-deprecate branch November 12, 2022 07:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic-asyncio
3 participants
@kumaraditya303 @gvanrossum @bedevere-bot