Skip to content

gh-94808:Improve coverage of PyObject_Print #98749

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Apr 1, 2024
Merged

gh-94808:Improve coverage of PyObject_Print #98749

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
7055a43
Improve coverage of PyObject_Print
MonadChains Oct 26, 2022
562b9d2
Merge branch 'main' into gh-94808/improve-coverage-pyobject-print
MonadChains Oct 27, 2022
25c24e4
Close file when error is returned
MonadChains Oct 28, 2022
64d8d19
Merge branch 'main' into gh-94808/improve-coverage-pyobject-print
MonadChains Nov 1, 2022
2202e4a
Rework negative reference test
MonadChains Nov 1, 2022
2bbb608
Merge in the main branch
encukou Mar 25, 2024
abf998e
Move the new tests
encukou Mar 25, 2024
d8e2e0e
Nitpicks
encukou Mar 25, 2024
355e8e4
Use Py_SET_REFCNT rather than ob_refcnt
encukou Mar 25, 2024
c14d4dd
Merge in the main branch
encukou Apr 1, 2024
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Use Py_SET_REFCNT rather than ob_refcnt
  • Loading branch information
@encukou
encukou committed Mar 25, 2024
commit 355e8e43102c3fc8a04e60b51e4df37a6fc89caf
4 changes: 2 additions & 2 deletions Modules/_testcapi/object.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ pyobject_print_noref_object(PyObject *self, PyObject *args)

test_string = PyUnicode_FromString("Spam spam spam");

test_string->ob_refcnt = 0;
Py_SET_REFCNT(test_string, 0);

PyOS_snprintf(correct_string, 100, "<refcnt %zd at %p>",
Py_REFCNT(test_string), (void *)test_string);
Expand All @@ -81,7 +81,7 @@ pyobject_print_noref_object(PyObject *self, PyObject *args)

fclose(fp);

test_string->ob_refcnt = 1;
Py_SET_REFCNT(test_string, 1);
Py_DECREF(test_string);

return PyUnicode_FromString(correct_string);
Expand Down