gh-97850: Deprecate find_loader and get_loader in pkgutil

Doc/whatsnew/3.12.rst

@@ -251,6 +251,11 @@ Deprecated
  :exc:`ImportWarning`).
  (Contributed by Brett Cannon in :gh:`65961`.)
 
+* :func:`pkgutil.find_module` and :func:`pkgutil.get_module`
+ now raise :exc:`DeprecationWarning`;
+ use :func:`importlib.util.find_spec` instead.
+ (Contributed by Nikita Sobolev in :gh:`97850`.)
+
 
 Pending Removal in Python 3.13
 ------------------------------

Lib/pkgutil.py

@@ -465,6 +465,10 @@ def get_loader(module_or_name):
  If the named module is not already imported, its containing package
  (if any) is imported, in order to establish the package __path__.
  """
+ warnings._deprecated("pkgutil.get_loader",
+ f"{warnings._DEPRECATED_MSG}; "
+ "use importlib.util.find_spec instead",
+ remove=(3, 14))
  if module_or_name in sys.modules:
  module_or_name = sys.modules[module_or_name]
  if module_or_name is None:
@@ -489,6 +493,10 @@ def find_loader(fullname):
  importlib.util.find_spec that converts most failures to ImportError
  and only returns the loader rather than the full spec
  """
+ warnings._deprecated("pkgutil.find_loader",
+ f"{warnings._DEPRECATED_MSG}; "
+ "use importlib.util.find_spec instead",
+ remove=(3, 14))
  if fullname.startswith('.'):
  msg = "Relative module name {!r} not supported".format(fullname)
  raise ImportError(msg)

Lib/test/test_pkgutil.py

@@ -1,6 +1,6 @@
 from pathlib import Path
 from test.support.import_helper import unload, CleanImport
-from test.support.warnings_helper import check_warnings
+from test.support.warnings_helper import check_warnings, ignore_warnings
 import unittest
 import sys
 import importlib
@@ -549,25 +549,18 @@ def test_loader_deprecated(self):
  with self.check_deprecated():
  pkgutil.ImpLoader("", "", "", "")
 
- def test_get_loader_avoids_emulation(self):
- with check_warnings() as w:
- self.assertIsNotNone(pkgutil.get_loader("sys"))
- self.assertIsNotNone(pkgutil.get_loader("os"))
- self.assertIsNotNone(pkgutil.get_loader("test.support"))
- self.assertEqual(len(w.warnings), 0)
-
  @unittest.skipIf(__name__ == '__main__', 'not compatible with __main__')
+ @ignore_warnings(category=DeprecationWarning)
  def test_get_loader_handles_missing_loader_attribute(self):
  global __loader__
  this_loader = __loader__
  del __loader__
  try:
- with check_warnings() as w:
- self.assertIsNotNone(pkgutil.get_loader(__name__))
- self.assertEqual(len(w.warnings), 0)
+ self.assertIsNotNone(pkgutil.get_loader(__name__))
  finally:
  __loader__ = this_loader
 
+ @ignore_warnings(category=DeprecationWarning)
  def test_get_loader_handles_missing_spec_attribute(self):
  name = 'spam'
  mod = type(sys)(name)
@@ -577,6 +570,7 @@ def test_get_loader_handles_missing_spec_attribute(self):
  loader = pkgutil.get_loader(name)
  self.assertIsNone(loader)
 
+ @ignore_warnings(category=DeprecationWarning)
  def test_get_loader_handles_spec_attribute_none(self):
  name = 'spam'
  mod = type(sys)(name)
@@ -586,6 +580,7 @@ def test_get_loader_handles_spec_attribute_none(self):
  loader = pkgutil.get_loader(name)
  self.assertIsNone(loader)
 
+ @ignore_warnings(category=DeprecationWarning)
  def test_get_loader_None_in_sys_modules(self):
  name = 'totally bogus'
  sys.modules[name] = None
@@ -595,18 +590,28 @@ def test_get_loader_None_in_sys_modules(self):
  del sys.modules[name]
  self.assertIsNone(loader)
 
+ def test_get_loader_is_deprecated(self):
+ for module in ["sys", "os", "test.support"]:
+ with check_warnings(
+ (r".*\bpkgutil.get_loader\b.*", DeprecationWarning),
+ ):
+ res = pkgutil.get_loader(module)
+ self.assertIsNotNone(res)
+
+ def test_find_loader_is_deprecated(self):
+ for module in ["sys", "os", "test.support"]:
+ with check_warnings(
+ (r".*\bpkgutil.find_loader\b.*", DeprecationWarning),
+ ):
+ res = pkgutil.find_loader(module)
+ self.assertIsNotNone(res)
+
+ @ignore_warnings(category=DeprecationWarning)
  def test_find_loader_missing_module(self):
  name = 'totally bogus'
  loader = pkgutil.find_loader(name)
  self.assertIsNone(loader)
 
- def test_find_loader_avoids_emulation(self):
- with check_warnings() as w:
- self.assertIsNotNone(pkgutil.find_loader("sys"))
- self.assertIsNotNone(pkgutil.find_loader("os"))
- self.assertIsNotNone(pkgutil.find_loader("test.support"))
- self.assertEqual(len(w.warnings), 0)
-
  def test_get_importer_avoids_emulation(self):
  # We use an illegal path so *none* of the path hooks should fire
  with check_warnings() as w:

Misc/NEWS.d/next/Library/2022-10-21-16-23-31.gh-issue-97850.N46coo.rst

@@ -0,0 +1,2 @@
+Deprecate :func:`pkgutil.find_module` and :func:`pkgutil.get_module`
+in favor of :func:`importlib.util.find_spec`.