gh-97943: PyFunction_GetAnnotations should return a borrowed reference. #97949
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
…ference. It was returning a new reference, which isn't how it used to work, and isn't how it's documented.
warsaw approved these changes Oct 6, 2022
There was a problem hiding this comment.
I know it's shocking, but @larryhastings is right! It is documented to return a borrowed reference, and the implementation should match the documentation.
methane approved these changes Oct 6, 2022
pablogsal added the 🔨 test-with-buildbots 
| 🤖 New build scheduled with the buildbot fleet by @pablogsal for commit d46f37e 🤖 If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again. |
bedevere-bot removed the 🔨 test-with-buildbots 
| Thanks @larryhastings for the PR, and @pablogsal for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11. |
| GH-97985 is a backport of this pull request to the 3.11 branch. |
| Thanks @larryhastings for the PR, and @pablogsal for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11. |
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 6, 2022
…ference. (pythonGH-97949) (cherry picked from commit 6bfb0be) Co-authored-by: larryhastings <larry@hastings.org>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 6, 2022
…ference. (pythonGH-97949) (cherry picked from commit 6bfb0be) Co-authored-by: larryhastings <larry@hastings.org>
| Thanks @larryhastings for the PR, and @pablogsal for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10. |
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 6, 2022
…ference. (pythonGH-97949) (cherry picked from commit 6bfb0be) Co-authored-by: larryhastings <larry@hastings.org>
| GH-97989 is a backport of this pull request to the 3.10 branch. |
carljm added a commit to carljm/cpython that referenced this pull request Oct 6, 2022
* main: fixes pythongh-96078: os.sched_yield release the GIL while calling sched_yield(2). (pythongh-97965) pythongh-65961: Do not rely solely on `__cached__` (pythonGH-97990) pythongh-97850: Remove the open issues section from the import reference (python#97935) Docs: pin sphinx-lint (pythonGH-97992) pythongh-94590: add signatures to operator itemgetter, attrgetter, methodcaller (python#94591) Add Pynche's move to the What's new in 3.11 (python#97974) pythongh-97781: Apply changes from importlib_metadata 5. (pythonGH-97785) pythongh-86482: Document assignment expression need for ()s (python#23291) pythongh-97943: PyFunction_GetAnnotations should return a borrowed reference. (python#97949) pythongh-94808: Coverage: Test that maximum indentation level is handled (python#95926)
ambv pushed a commit that referenced this pull request Oct 7, 2022
carljm added a commit to carljm/cpython that referenced this pull request Oct 8, 2022
* main: pythonGH-97002: Prevent `_PyInterpreterFrame`s from backing more than one `PyFrameObject` (pythonGH-97996) pythongh-97973: Return all necessary information from the tokenizer (pythonGH-97984) fixes pythongh-96078: os.sched_yield release the GIL while calling sched_yield(2). (pythongh-97965) pythongh-65961: Do not rely solely on `__cached__` (pythonGH-97990) pythongh-97850: Remove the open issues section from the import reference (python#97935) Docs: pin sphinx-lint (pythonGH-97992) pythongh-94590: add signatures to operator itemgetter, attrgetter, methodcaller (python#94591) Add Pynche's move to the What's new in 3.11 (python#97974) pythongh-97781: Apply changes from importlib_metadata 5. (pythonGH-97785) pythongh-86482: Document assignment expression need for ()s (python#23291) pythongh-97943: PyFunction_GetAnnotations should return a borrowed reference. (python#97949)
mpage pushed a commit to mpage/cpython that referenced this pull request Oct 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
It was returning a new reference, which isn't how it used to work, and isn't how it's documented.