[3.10] gh-88050: Fix asyncio subprocess to kill process cleanly when process is blocked (GH-32073) #97916
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
…rocess is blocked (pythonGH-32073) (cherry picked from commit 7015e13) Co-authored-by: Kumar Aditya <59607654+kumaraditya303@users.noreply.github.com>
gvanrossum approved these changes Oct 5, 2022
| Sorry, I can't merge this PR. Reason: |
Co-authored-by: Kumar Aditya <59607654+kumaraditya303@users.noreply.github.com>
| I am closing this as CI appears to be hanging and 3.10 has diverged too much from main so not worth investing more time into this. This would probably require more fixes to be backported from main around subprocesses. |
| Maybe you gave up too soon? There are some current issues with GitHub Actions that might have caused the hang. (Then again, maybe it was waiting for the |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
(cherry picked from commit 7015e13)
Co-authored-by: Kumar Aditya 59607654+kumaraditya303@users.noreply.github.com