[3.5] bpo-28598: Support __rmod__ for RHS subclasses of str in % string formatting operations #94
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
…tr in % string formatting operations
Python/ceval.c Outdated
| PyObject *res; | ||
| if (PyUnicode_CheckExact(dividend) && ( | ||
| !PyUnicode_Check(divisor) || PyUnicode_CheckExact(divisor))) { | ||
| // fast path; string formatting, but not if the RHS is a str subclass |
Member
There was a problem hiding this comment.
Do we support // ... style comments in 3.5?
Contributor Author
There was a problem hiding this comment.
Ah, no, I forgot about C89 vs C99. 3.5 still supports C89 only so the comment will have to be updated.
added 2 commits February 27, 2017 14:39
…into bpo28598_backport_3.5
serhiy-storchaka changed the title 
serhiy-storchaka approved these changes Feb 27, 2017
akruis pushed a commit to akruis/cpython that referenced this pull request Sep 9, 2017
This commit makes calls to an initialiser method (__init__(self)) stackless, if soft switching is enabled. https://bitbucket.org/stackless-dev/stackless/issues/94 (grafted from dc2e43c1dbd20f279704c287eb0e2b69e0d14c7f and 43fa00988749)
akruis pushed a commit to akruis/cpython that referenced this pull request Sep 9, 2017
This was referenced Feb 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Backport of #51