bpo-34523: Use _PyCoreConfig instead of globals #9005
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Get configuratiom the core configuration of the interpreter, rather than getting global configuration variables. For example, replace Py_QuietFlag with core_config->quiet.
| Unfortunately, the description does not tell much about "Why this is good?" (edit: link went to different PR) |
For the long term, I plan to deprecate global variables, especially global configuration variables like Py_QuietFlag. Moreover, I would like to support running two Python interpreters inside the same process but with two different configurations. See https://www.python.org/dev/peps/pep-0554/ for more information about Eric Snow's project @ericsnowcurrently. |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Get configuratiom the core configuration of the interpreter, rather
than getting global configuration variables. For example, replace
Py_QuietFlag with core_config->quiet.
https://bugs.python.org/issue34523