bpo-33614: Ensures module definition files for the stable ABI on Windows are correctly regenerated #7165
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
…ows are correctly regenerated.
| Thanks @zooba for the PR 🌮🎉.. I'm working now to backport this PR to: 3.6, 3.7. |
| GH-7167 is a backport of this pull request to the 3.7 branch. |
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 28, 2018
…ows are correctly regenerated. (pythonGH-7165) (cherry picked from commit e97ba4c) Co-authored-by: Steve Dower <steve.dower@microsoft.com>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 28, 2018
…ows are correctly regenerated. (pythonGH-7165) (cherry picked from commit e97ba4c) Co-authored-by: Steve Dower <steve.dower@microsoft.com>
| GH-7168 is a backport of this pull request to the 3.6 branch. |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Also includes a minor improvement to
find_MSBuild.batto handle the case where%MSBUILD%is set to the directory rather than the executable.