Skip to content

bpo-31708: Allow async generator expressions in synchronous functions #3905

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 6, 2017
Merged

bpo-31708: Allow async generator expressions in synchronous functions #3905

merged 1 commit into from
Oct 6, 2017

Conversation

1st1
Copy link
Member

@1st1 1st1 commented Oct 6, 2017 •
edited by bedevere-bot
Loading

@1st1 1st1 requested a review from ncoghlan October 6, 2017 06:14
ncoghlan
ncoghlan approved these changes Oct 6, 2017
View reviewed changes
Copy link
Contributor

@ncoghlan ncoghlan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The updated tests make sure that only async genexps are permitted (just like any other async def), so +1 from me.
@1st1 1st1 merged commit b8ab9d3 into python:master Oct 6, 2017
@1st1 1st1 deleted the async_genx branch October 6, 2017 06:58
@1st1
Copy link
Member Author

1st1 commented Oct 6, 2017

Thanks for the review, Nick!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

4 participants

@1st1 @ncoghlan @the-knights-who-say-ni @bedevere-bot