Skip to content

bpo-31672: string: Use re.A | re.I flag for identifier pattern #3872

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Oct 13, 2017
Merged

bpo-31672: string: Use re.A | re.I flag for identifier pattern #3872

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
c43ec46
bpo-31672: strings.Template should use re.A flag
methane Oct 3, 2017
3862b33
Update comment
methane Oct 4, 2017
586ef34
Use -i local flag, as suggested by Serhiy
methane Oct 11, 2017
8b2f429
Add NEWS and update document
methane Oct 11, 2017
32b765b
Update based on review.
methane Oct 13, 2017
1e4bb62
Update string.rst
methane Oct 13, 2017
961a206
Update string.rst
methane Oct 13, 2017
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion Lib/string.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,7 @@ class Template(metaclass=_TemplateMetaclass):
delimiter = '$'
idpattern = r'[_a-z][_a-z0-9]*'
braceidpattern = None
flags = _re.IGNORECASE
flags = _re.IGNORECASE | _re.ASCII
Copy link
Member

@warsaw warsaw Oct 4, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would add a comment here too, since a person reading the code may not notice the restored flag below.

def __init__(self, template):
self.template = template
Expand Down Expand Up @@ -157,6 +157,10 @@ def convert(mo):
return self.pattern.sub(convert, self.template)


# We use re.I | re.A when compiling Template.idpattern, but restore old flag
# for backward compatibility.
Template.flags = _re.IGNORECASE
Copy link
Member

@warsaw warsaw Oct 4, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about:

We use re.I | re.A while compiling Template.idpattern in the metaclass above, but since
flags is part of the public API, we restore its original documented value for backward
compatibility.

?


########################################################################
# the Formatter class
Expand Down