Skip to content

bpo-31418: Fix an assertion failure in case of an exception with a bad __module__ attribute #3539

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
serhiy-storchaka merged 4 commits into from
Sep 13, 2017
Merged

bpo-31418: Fix an assertion failure in case of an exception with a bad __module__ attribute #3539

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f78186a
init commit
orenmn Sep 13, 2017
bf19d82
fix NEWS.d item
orenmn Sep 13, 2017
ea86877
fix NEWS.d item
orenmn Sep 13, 2017
c8d8155
another fix of the NEWS.d item
orenmn Sep 13, 2017
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions Misc/NEWS.d/next/Core and Builtins/2017-09-13-13-03-52.bpo-31418.rS-FlC.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
Fix an assertion failure in case of an exception with a bad ``__module__``
Copy link
Member

@serhiy-storchaka serhiy-storchaka Sep 13, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"in PyErr_WriteUnraisable()"
attribute. Patch by Oren Milman.
2 changes: 1 addition & 1 deletion Python/errors.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -961,7 +961,7 @@ PyErr_WriteUnraisable(PyObject *obj)
}

moduleName = _PyObject_GetAttrId(t, &PyId___module__);
if (moduleName == NULL) {
if (moduleName == NULL || !PyUnicode_Check(moduleName)) {
PyErr_Clear();
if (PyFile_WriteString("<unknown>", f) < 0)
goto done;
Expand Down