Skip to content

bpo-47199: multiprocessing: micro-optimize Connection.send_bytes() method #32247

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from May 3, 2022
Merged

bpo-47199: multiprocessing: micro-optimize Connection.send_bytes() method #32247

merged 1 commit into from May 3, 2022

Conversation

ghost
Copy link

@ghost ghost commented Apr 2, 2022 •
edited by ghost
Loading

memoryview.cast() and memoryview.nbytes were added in Python 3.3.

https://bugs.python.org/issue47199
MaxwellDupre
MaxwellDupre approved these changes Apr 23, 2022
View reviewed changes
Copy link
Contributor

@MaxwellDupre MaxwellDupre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ran the multiprocessing tests and results ok.
@corona10 corona10 self-assigned this Apr 30, 2022
@wjssz @corona10
multiprocessing: micro-optimize Connection.send_bytes() method
734a4af 
When m.itemsize > 1, avoid copying memory.
corona10
corona10 approved these changes May 3, 2022
View reviewed changes
Copy link
Member

@corona10 corona10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm
@corona10 corona10 merged commit 1699128 into python:main May 3, 2022
@animalize animalize mannequin mentioned this pull request Apr 10, 2022
Closed
@ghost ghost deleted the send_bytes branch May 4, 2022 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip news
5 participants
@corona10 @MaxwellDupre @the-knights-who-say-ni @bedevere-bot @wjssz