bpo-46841: Use *inline* caching for BINARY_OP
#31543
Merged
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Here's a sort-of-rough first pass at implementing this idea.
BINARY_OP
is easy to start with, since it only uses its cache for the adaptivecounter
member. Initial perf testing doesn't show any impact, which I think is good (it means that the basic idea works well, even when the cache isn't being used).Related changes:
dis
utilities grow ashow_caches
parameter, defaulting toFalse
.wordcode_helpers.h
has been moved intocompile.c
.https://bugs.python.org/issue46841