bpo-46820: Refactor tests for ambiguous end of numerical literal #31494
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
serhiy-storchaka added tests 
pxeger reviewed Feb 22, 2022
| with self.assertWarns(DeprecationWarning): | ||
| compile(test, "<testcase>", "eval") | ||
| | ||
| for num in "0xf", "0o7", "0b1", "9", "0", "1.", "1e3", "1j": |
There was a problem hiding this comment.
Is now a better time to suggest adding an underscore literal 1_000?
There was a problem hiding this comment.
There are too many different use cases with underscores: 0x_f, 0x1_f, 0o_7, 0o1_7, 0b_1, 0b1_1, 1., 1_0., 1.0_0, etc. And none of them is related because an underscore cannot ends the numeric literal, and it does not affect interpretation of other characters.
It will increase test coverage.
| Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10. |
| GH-31566 is a backport of this pull request to the 3.10 branch. |
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Feb 25, 2022
…honGH-31494) (cherry picked from commit 98c3bea) Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
miss-islington added a commit that referenced this pull request Feb 25, 2022
asvetlov pushed a commit that referenced this pull request Feb 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
https://bugs.python.org/issue46820