bpo-46556: emit DeprecationWarning from pathlib.Path.__enter__() #30971
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
In Python 3.9 / bpo-39682 we made `Path.__exit__()` a no-op, and added a comment in the code mentioning that it should be deprecated in future. The future is here, so let's deprecate it.
sobolevn reviewed Jan 28, 2022
tirkarthi reviewed Jan 30, 2022
There was a problem hiding this comment.
There are deprecation warnings emitted by other tests too :
./python -Wall -m test test_pathlib 0:00:00 load avg: 0.37 Run tests sequentially 0:00:00 load avg: 0.37 [1/1] test_pathlib /home/karthikeyan/stuff/python/cpython/Lib/test/test_pathlib.py:1833: DeprecationWarning: pathlib.Path.__enter__() is deprecated and scheduled for removal in Python 3.13. Path objects should not be used as context managers. with p: /home/karthikeyan/stuff/python/cpython/Lib/test/test_pathlib.py:1842: DeprecationWarning: pathlib.Path.__enter__() is deprecated and scheduled for removal in Python 3.13. Path objects should not be used as context managers. with p: /home/karthikeyan/stuff/python/cpython/Lib/test/test_pathlib.py:1833: DeprecationWarning: pathlib.Path.__enter__() is deprecated and scheduled for removal in Python 3.13. Path objects should not be used as context managers. with p: /home/karthikeyan/stuff/python/cpython/Lib/test/test_pathlib.py:1842: DeprecationWarning: pathlib.Path.__enter__() is deprecated and scheduled for removal in Python 3.13. Path objects should not be used as context managers. with p: == Tests result: SUCCESS == 1 test OK. Total duration: 586 ms Tests result: SUCCESS 
brettcannon approved these changes Feb 4, 2022
brettcannon reviewed Feb 4, 2022
| I'm ready to merge this, but there was a CI hiccup; just trying to work passed that. |
| @barneygale: Status check is done, and it's a failure ❌ . |
| @barneygale: Status check is done, and it's a failure ❌ . |
| @barneygale thanks! |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
In Python 3.9,
Path.__exit__()was made a no-op.https://bugs.python.org/issue46556
Automerge-Triggered-By: GH:brettcannon